From: Kevin Wolf <kwolf@redhat.com>
To: Hu Tao <hutao@cn.fujitsu.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v7 for 2.0 4/4] qcow2: Add full image preallocation option
Date: Thu, 20 Mar 2014 14:38:32 +0100 [thread overview]
Message-ID: <20140320133832.GB3450@noname.redhat.com> (raw)
In-Reply-To: <6eff2de18cc1e860f31a1ea9c1afc71b8ee12f48.1395035846.git.hutao@cn.fujitsu.com>
Am 17.03.2014 um 07:53 hat Hu Tao geschrieben:
> This adds a preallocation=full mode to qcow2 image creation, which
> creates a non-sparse image file.
>
> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
I see that you changed the implementation from bdrv_preallocate() to
bdrv_create() options in v4 after Stefan had asked whether
bdrv_preallocate() was really necessary or just complicating things.
In hindsight, do you really think the new code is simpler? I certainly
think this one is rather adventurous and the formulas to precalculate
the image file size are easy to get wrong.
Kevin
next prev parent reply other threads:[~2014-03-20 13:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 6:53 [Qemu-devel] [PATCH v7 for 2.0 0/4] qemu-img: add preallocation=full Hu Tao
2014-03-17 6:53 ` [Qemu-devel] [PATCH v7 for 2.0 1/4] qapi: introduce PreallocMode and a new PreallocMode full Hu Tao
2014-03-17 14:58 ` Eric Blake
2014-03-20 2:22 ` Hu Tao
2014-03-17 6:53 ` [Qemu-devel] [PATCH v7 for 2.0 2/4] raw, qcow2: don't convert file size to sector size Hu Tao
2014-03-17 6:53 ` [Qemu-devel] [PATCH v7 for 2.0 3/4] raw-posix: Add full image preallocation option Hu Tao
2014-03-20 13:22 ` Kevin Wolf
2014-03-28 2:33 ` hutao
2014-03-17 6:53 ` [Qemu-devel] [PATCH v7 for 2.0 4/4] qcow2: " Hu Tao
2014-03-20 13:38 ` Kevin Wolf [this message]
2014-05-07 2:39 ` Hu Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140320133832.GB3450@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=hutao@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).