qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.0 2/2] dataplane: replace iothread object_add() with embedded instance
Date: Fri, 21 Mar 2014 09:43:08 +0100	[thread overview]
Message-ID: <20140321084308.GA10066@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <532AFD42.7030602@redhat.com>

On Thu, Mar 20, 2014 at 03:37:54PM +0100, Paolo Bonzini wrote:
> Il 20/03/2014 15:06, Stefan Hajnoczi ha scritto:
> >+        object_initialize(&s->internal_iothread_obj,
> >+                          sizeof(s->internal_iothread_obj),
> >+                          TYPE_IOTHREAD);
> >+        user_creatable_complete(OBJECT(&s->internal_iothread_obj), &error_abort);
> 
> Perhaps you need an object_property_add_child here?  Otherwise the
> link points to an object without a canonical path.  Can do it as a
> follow-up though.

The link doesn't exist yet since we're still using a qdev property.

I will add the child property when we switch to a link in QEMU 2.1.  In
order to do that, I posted an RFC series that shows how I propose to
clean up the virtio transport/device split which is currently broken.

Stefan

  reply	other threads:[~2014-03-21  8:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-20 14:06 [Qemu-devel] [PATCH for-2.0 0/2] dataplane: fix internal IOThread name collision Stefan Hajnoczi
2014-03-20 14:06 ` [Qemu-devel] [PATCH for-2.0 1/2] iothread: make IOThread struct definition public Stefan Hajnoczi
2014-03-20 14:06 ` [Qemu-devel] [PATCH for-2.0 2/2] dataplane: replace iothread object_add() with embedded instance Stefan Hajnoczi
2014-03-20 14:37   ` Paolo Bonzini
2014-03-21  8:43     ` Stefan Hajnoczi [this message]
2014-03-20 14:37 ` [Qemu-devel] [PATCH for-2.0 0/2] dataplane: fix internal IOThread name collision Paolo Bonzini
2014-03-20 14:52 ` Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140321084308.GA10066@stefanha-thinkpad.redhat.com \
    --to=stefanha@gmail.com \
    --cc=borntraeger@de.ibm.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).