From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33860)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WQv2v-00072I-Rt
	for qemu-devel@nongnu.org; Fri, 21 Mar 2014 04:43:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WQv2n-0001ve-9V
	for qemu-devel@nongnu.org; Fri, 21 Mar 2014 04:43:21 -0400
Received: from mail-we0-x230.google.com ([2a00:1450:400c:c03::230]:61157)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WQv2n-0001vX-2z
	for qemu-devel@nongnu.org; Fri, 21 Mar 2014 04:43:13 -0400
Received: by mail-we0-f176.google.com with SMTP id x48so1373449wes.35
	for <qemu-devel@nongnu.org>; Fri, 21 Mar 2014 01:43:11 -0700 (PDT)
Date: Fri, 21 Mar 2014 09:43:08 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20140321084308.GA10066@stefanha-thinkpad.redhat.com>
References: <1395324392-2142-1-git-send-email-stefanha@redhat.com>
	<1395324392-2142-3-git-send-email-stefanha@redhat.com>
	<532AFD42.7030602@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <532AFD42.7030602@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.0 2/2] dataplane: replace iothread
 object_add() with embedded instance
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Christian Borntraeger <borntraeger@de.ibm.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On Thu, Mar 20, 2014 at 03:37:54PM +0100, Paolo Bonzini wrote:
> Il 20/03/2014 15:06, Stefan Hajnoczi ha scritto:
> >+        object_initialize(&s->internal_iothread_obj,
> >+                          sizeof(s->internal_iothread_obj),
> >+                          TYPE_IOTHREAD);
> >+        user_creatable_complete(OBJECT(&s->internal_iothread_obj), &error_abort);
> 
> Perhaps you need an object_property_add_child here?  Otherwise the
> link points to an object without a canonical path.  Can do it as a
> follow-up though.

The link doesn't exist yet since we're still using a qdev property.

I will add the child property when we switch to a link in QEMU 2.1.  In
order to do that, I posted an RFC series that shows how I propose to
clean up the virtio transport/device split which is currently broken.

Stefan