From: Stuart Brady <sdb@zubnet.me.uk>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 02/14] tcg: Add INDEX_op_trunc_i32
Date: Fri, 21 Mar 2014 23:39:48 +0000 [thread overview]
Message-ID: <20140321233948.GA13931@zubnet.me.uk> (raw)
In-Reply-To: <20140321233512.GA12223@zubnet.me.uk>
On Fri, Mar 21, 2014 at 11:35:12PM +0000, Stuart Brady wrote:
> On Mon, Mar 17, 2014 at 11:37:44AM -0700, Richard Henderson wrote:
> > diff --git a/tcg/README b/tcg/README
> > index f178212..160cbe8 100644
> > --- a/tcg/README
> > +++ b/tcg/README
> > @@ -306,6 +306,11 @@ This operation would be equivalent to
> >
> > dest = (t1 & ~0x0f00) | ((t2 << 8) & 0x0f00)
> >
> > +* trunc_i32 t0, t1, pos
> > +
> > +For 64-bit hosts only, right shift the 64-bit input T1 by POS and
> > +truncate to 32-bit output T0. Depending on the host, this may be
> > +a simple mov/shift, or may require additional canonicalization.
>
> Surely trunc_rshift_i64_i32, which is used elsewhere in this patch?
... but not used consistently, so this affects more than just the README.
Forgot to mention that! :-)
> ... or trunc_shr_i64_i32 as we use 'shr' for the existing shift-right op.
Cheers,
Stuart
next prev parent reply other threads:[~2014-03-21 23:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 18:37 [Qemu-devel] [PATCH 00/14] tcg/sparc v8plus code generation Richard Henderson
2014-03-17 18:37 ` [Qemu-devel] [PATCH 01/14] tcg: Fix missed pointer size != TCG_TARGET_REG_BITS changes Richard Henderson
2014-03-17 18:37 ` [Qemu-devel] [PATCH 02/14] tcg: Add INDEX_op_trunc_i32 Richard Henderson
2014-03-21 23:35 ` Stuart Brady
2014-03-21 23:39 ` Stuart Brady [this message]
2014-03-17 18:37 ` [Qemu-devel] [PATCH 03/14] tcg-sparc: Remove most uses of TCG_TARGET_REG_BITS Richard Henderson
2014-03-17 18:37 ` [Qemu-devel] [PATCH 04/14] tcg-sparc: Support trunc_i32 Richard Henderson
2014-03-17 18:37 ` [Qemu-devel] [PATCH 05/14] tcg-sparc: Use 64-bit registers with sparcv8plus Richard Henderson
2014-03-17 18:37 ` [Qemu-devel] [PATCH 06/14] tcg-sparc: Use the RETURN instruction Richard Henderson
2014-03-17 18:37 ` [Qemu-devel] [PATCH 07/14] tcg-sparc: Implement muls2_i32 Richard Henderson
2014-03-17 18:37 ` [Qemu-devel] [PATCH 08/14] tcg-sparc: Tidy check_fit_* tests Richard Henderson
2014-03-17 18:37 ` [Qemu-devel] [PATCH 09/14] tcg-sparc: Don't handle mov/movi in tcg_out_op Richard Henderson
2014-03-17 18:37 ` [Qemu-devel] [PATCH 10/14] tcg-sparc: Hoist common argument loads " Richard Henderson
2014-03-17 18:37 ` [Qemu-devel] [PATCH 11/14] tcg-sparc: Fixup function argument types Richard Henderson
2014-03-17 18:37 ` [Qemu-devel] [PATCH 12/14] tcg-sparc: Fix small 32-bit movi Richard Henderson
2014-03-17 18:37 ` [Qemu-devel] [PATCH 13/14] tcg-sparc: Fix 32-bit constant arguments tests Richard Henderson
2014-03-22 9:48 ` Stuart Brady
2014-03-22 17:08 ` Richard Henderson
2014-03-17 18:37 ` [Qemu-devel] [PATCH 14/14] tcg-sparc: Accept stores of zero Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140321233948.GA13931@zubnet.me.uk \
--to=sdb@zubnet.me.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).