From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35745) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WRf2K-0000CR-1j for qemu-devel@nongnu.org; Sun, 23 Mar 2014 05:49:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WRf2E-0000wS-0w for qemu-devel@nongnu.org; Sun, 23 Mar 2014 05:49:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25829) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WRf2D-0000wN-PO for qemu-devel@nongnu.org; Sun, 23 Mar 2014 05:49:41 -0400 Date: Sun, 23 Mar 2014 11:49:43 +0200 From: "Michael S. Tsirkin" Message-ID: <20140323094943.GA6989@redhat.com> References: <1395350099-14664-1-git-send-email-marcel.a@redhat.com> <532B645B.5020507@redhat.com> <1395353214.21800.6.camel@localhost.localdomain> <532B6B27.2080105@redhat.com> <1395354837.21800.12.camel@localhost.localdomain> <532B76E5.7090608@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <532B76E5.7090608@redhat.com> Subject: Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: peter.maydell@linaro.org, Marcel Apfelbaum , aik@ozlabs.ru, mjt@tls.msk.ru, qemu-devel@nongnu.org, stefanha@redhat.com, Laszlo Ersek , afaerber@suse.de, rth@twiddle.net On Fri, Mar 21, 2014 at 12:16:53AM +0100, Paolo Bonzini wrote: > Il 20/03/2014 23:33, Marcel Apfelbaum ha scritto: > >I've seen something like that somewhere, but I didn't quite like it. > >I was looking for something more elegant as I was *almost* sure > >this kind of solution will not pass the reviews :) > > > >But maybe I'll try this, let's see what happens, > > If all you're looking for is bigendian (disabling iasl disassembly > on bigendian makes sense), your patch v2 is fine. > > Assembling ASL on bigendian is supported by at least Fedora and > Debian (and hence Ubuntu). > > Paolo At this point I'm confused. If iasl compiler is broken, we should detect and fix that. It might be ok to just detect endian-ness as a quick work-around. BTW configure already has code to detect endian-ness: if test "$bigendian" = "yes" ; then echo "HOST_WORDS_BIGENDIAN=y" >> $config_host_mak fi If only the dis-assembler is broken, we should only detect that when running tests. Using expected files for this should be fine. -- MST