From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35915)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WRf42-0001Cv-5x
	for qemu-devel@nongnu.org; Sun, 23 Mar 2014 05:51:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WRf3w-0001Tb-7O
	for qemu-devel@nongnu.org; Sun, 23 Mar 2014 05:51:34 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41232)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WRf3v-0001TW-VK
	for qemu-devel@nongnu.org; Sun, 23 Mar 2014 05:51:28 -0400
Date: Sun, 23 Mar 2014 11:51:33 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140323095133.GB6989@redhat.com>
References: <1395350099-14664-1-git-send-email-marcel.a@redhat.com>
	<532B645B.5020507@redhat.com>
	<1395353214.21800.6.camel@localhost.localdomain>
	<CAFEAcA8agvVSy-_UmCO4g+RbvqhWS=NyA7GNGNvSmg9BQZnCnQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA8agvVSy-_UmCO4g+RbvqhWS=NyA7GNGNvSmg9BQZnCnQ@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run
 iasl on big endian machines
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Marcel Apfelbaum <marcel.a@redhat.com>, Alexey Kardashevskiy <aik@ozlabs.ru>, Michael Tokarev <mjt@tls.msk.ru>, QEMU Developers <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>, Richard Henderson <rth@twiddle.net>

On Thu, Mar 20, 2014 at 10:17:14PM +0000, Peter Maydell wrote:
> On 20 March 2014 22:06, Marcel Apfelbaum <marcel.a@redhat.com> wrote:
> > On Thu, 2014-03-20 at 22:57 +0100, Paolo Bonzini wrote:
> >> Il 20/03/2014 22:14, Marcel Apfelbaum ha scritto:
> >> > +# All known versions of iasl on BE machines are broken.
> >> > +# TODO: add detection code once a non-broken version makes an appearance.
> >> > +if ($iasl -h > /dev/null 2>&1) &&
> >> > +   (lscpu | grep "Byte Order" | grep --quiet "Little Endian" ); then
> >>
> >> lscpu is not portable.
> > I am open to suggestions...
> 
> echo "trivial iasl source" | iasl --compile-options | iasl
> --disassemble-options | grep "error"
> 
> Fill in the handwaving with actual syntax ;-)
> 
> thanks
> -- PMM

True but whatever test we write, it's possible that a buggy iasl
passes it by luck.
Let's wait for a working iasl to appear on some BE machines.
When that happens, we'll be able to write a robust detection script.


-- 
MST