From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36079) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WRf5J-0002V9-90 for qemu-devel@nongnu.org; Sun, 23 Mar 2014 05:52:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WRf5D-0001bl-9u for qemu-devel@nongnu.org; Sun, 23 Mar 2014 05:52:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5567) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WRf5D-0001bf-0t for qemu-devel@nongnu.org; Sun, 23 Mar 2014 05:52:47 -0400 Date: Sun, 23 Mar 2014 11:52:52 +0200 From: "Michael S. Tsirkin" Message-ID: <20140323095252.GC6989@redhat.com> References: <1395350099-14664-1-git-send-email-marcel.a@redhat.com> <532B645B.5020507@redhat.com> <1395353214.21800.6.camel@localhost.localdomain> <1395355269.21800.19.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Marcel Apfelbaum , Alexey Kardashevskiy , Michael Tokarev , QEMU Developers , Stefan Hajnoczi , Paolo Bonzini , Andreas =?iso-8859-1?Q?F=E4rber?= , Richard Henderson On Thu, Mar 20, 2014 at 11:03:04PM +0000, Peter Maydell wrote: > On 20 March 2014 22:41, Marcel Apfelbaum wrote: > > On Thu, 2014-03-20 at 22:17 +0000, Peter Maydell wrote: > >> echo "trivial iasl source" | iasl --compile-options | iasl > >> --disassemble-options | grep "error" > >> > >> Fill in the handwaving with actual syntax ;-) > > > Problem with this solution is that if we start from the source, > > it will compile into a *wrong* AML (e.g header length will be BE and not LE), > > then the disassemble will *succeed* (!!!). > > However, the expected AML file will be in the right format and fail :(. > > Well, grep for 'some integer that comes out wrong due > to the iasl bug', if it doesn't always result in an error > like the case you reported to the iasl mailing list. > > You need to write this code at some point because we do > need to be able to configure-time detect whether we have > a working iasl or a broken one, once fixed ones get out > into the wild. It doesn't seem like it ought to be that hard > to just do it right to start with... > > thanks > -- PMM Hard to predict the future: it's possible that some distros will ship partially broken iasl on BE. We really need to see a working one to be sure ... -- MST