From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34175) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WS5J7-0006fn-7O for qemu-devel@nongnu.org; Mon, 24 Mar 2014 09:52:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WS4qI-0001mM-Pj for qemu-devel@nongnu.org; Mon, 24 Mar 2014 09:23:12 -0400 Date: Mon, 24 Mar 2014 14:19:59 +0100 From: Stefan Hajnoczi Message-ID: <20140324131959.GF4384@stefanha-thinkpad.redhat.com> References: <1395566923-5074-1-git-send-email-prasadjoshi.linux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1395566923-5074-1-git-send-email-prasadjoshi.linux@gmail.com> Subject: Re: [Qemu-devel] [PATCH 1/6] audio: set top level latch for each slot List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: alex@alex.org.uk, v.maffione@gmail.com, aik@ozlabs.ru, jan.kiszka@siemens.com, Prasad Joshi , riku.voipio@iki.fi, agraf@suse.de, chouteau@adacore.com, qemu-devel@nongnu.org, qemu-trivial@nongnu.org, av1474@comtv.ru, kraxel@redhat.com, aliguori@amazon.com, pbonzini@redhat.com, g.lettieri@iet.unipi.it, rizzo@iet.unipi.it, afaerber@suse.de On Sun, Mar 23, 2014 at 02:58:38PM +0530, Prasad Joshi wrote: > CSMKeyControll function is supposed to set the top level latch for each > slot. However, at the moment, it incorrectly updates only the first > slot. Patch fixes the problem. > > Signed-off-by: Prasad Joshi > --- > hw/audio/fmopl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Peter: This series has some fixes for QEMU 2.0 since they are bug fixes. > diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c > index 290a224..eb60c12 100644 > --- a/hw/audio/fmopl.c > +++ b/hw/audio/fmopl.c > @@ -725,7 +725,7 @@ INLINE void CSMKeyControll(OPL_CH *CH) > OPL_KEYOFF(slot2); > /* total level latch */ > slot1->TLL = slot1->TL + (CH->ksl_base>>slot1->ksl); > - slot1->TLL = slot1->TL + (CH->ksl_base>>slot1->ksl); > + slot2->TLL = slot2->TL + (CH->ksl_base>>slot2->ksl); > /* key on */ > CH->op1_out[0] = CH->op1_out[1] = 0; > OPL_KEYON(slot1); > -- > 1.8.1.2 >