From: Kevin Wolf <kwolf@redhat.com>
To: Prasad Joshi <prasadjoshi.linux@gmail.com>
Cc: qemu-trivial@nongnu.org, pl@kamp.de, qemu-devel@nongnu.org,
stefanha@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH for-2.0] qemu-img: mandate argument to 'qemu-img check --repair'
Date: Tue, 25 Mar 2014 12:07:51 +0100 [thread overview]
Message-ID: <20140325110751.GD3795@noname.str.redhat.com> (raw)
In-Reply-To: <1395686334-9498-1-git-send-email-prasadjoshi.linux@gmail.com>
Am 24.03.2014 um 19:38 hat Prasad Joshi geschrieben:
> qemu-img check --repair option accepts an argument. The argument to
> --repair switch can either be 'all' or 'leak'. Fix the long option to
> mandate argument with --repair switch.
>
> The patch fixes following segmentation fault
>
> Core was generated by `qemu-img check -f qcow2 --repair all t.qcow2'.
> Program terminated with signal 11, Segmentation fault.
> 0 in img_check (argc=6, argv=0x7fffab9b8a10) at qemu-img.c:588
> 588 if (!strcmp(optarg, "leaks")) {
> (gdb) bt
> 0 img_check (argc=6, argv=0x7fffab9b8a10) at qemu-img.c:588
> 1 __libc_start_main () from /lib/x86_64-linux-gnu/libc.so.6
> 2 _start ()
> (gdb)
>
> Signed-off-by: Prasad Joshi <prasadjoshi.linux@gmail.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Stefan, this should still go into 2.0.
Kevin
next prev parent reply other threads:[~2014-03-25 11:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-24 18:38 [Qemu-devel] [PATCH] qemu-img: mandate argument to 'qemu-img check --repair' Prasad Joshi
2014-03-24 18:57 ` Leandro Dorileo
2014-03-25 11:07 ` Kevin Wolf [this message]
2014-03-25 12:41 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140325110751.GD3795@noname.str.redhat.com \
--to=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=prasadjoshi.linux@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).