From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53322)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WSPDH-0008E3-36
	for qemu-devel@nongnu.org; Tue, 25 Mar 2014 07:08:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WSPDB-0001Gc-0N
	for qemu-devel@nongnu.org; Tue, 25 Mar 2014 07:08:11 -0400
Date: Tue, 25 Mar 2014 12:07:51 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20140325110751.GD3795@noname.str.redhat.com>
References: <1395686334-9498-1-git-send-email-prasadjoshi.linux@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1395686334-9498-1-git-send-email-prasadjoshi.linux@gmail.com>
Subject: Re: [Qemu-devel] [PATCH for-2.0] qemu-img: mandate argument to
 'qemu-img check --repair'
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Prasad Joshi <prasadjoshi.linux@gmail.com>
Cc: qemu-trivial@nongnu.org, pl@kamp.de, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com

Am 24.03.2014 um 19:38 hat Prasad Joshi geschrieben:
> qemu-img check --repair option accepts an argument. The argument to
> --repair switch can either be 'all' or 'leak'. Fix the long option to
> mandate argument with --repair switch.
> 
> The patch fixes following segmentation fault
> 
> Core was generated by `qemu-img check -f qcow2 --repair all t.qcow2'.
> Program terminated with signal 11, Segmentation fault.
> 0  in img_check (argc=6, argv=0x7fffab9b8a10) at qemu-img.c:588
> 588	            if (!strcmp(optarg, "leaks")) {
> (gdb) bt
>   0  img_check (argc=6, argv=0x7fffab9b8a10) at qemu-img.c:588
>   1  __libc_start_main () from /lib/x86_64-linux-gnu/libc.so.6
>   2  _start ()
> (gdb)
> 
> Signed-off-by: Prasad Joshi <prasadjoshi.linux@gmail.com>

Reviewed-by: Kevin Wolf <kwolf@redhat.com>

Stefan, this should still go into 2.0.

Kevin