* [Qemu-devel] [PATCH] qcow2: Remove FIXME comment, already fixed
@ 2014-03-24 6:06 Deepak Kathayat
2014-03-24 15:08 ` Leandro Dorileo
2014-03-25 12:47 ` Stefan Hajnoczi
0 siblings, 2 replies; 3+ messages in thread
From: Deepak Kathayat @ 2014-03-24 6:06 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Deepak Kathayat, stefanha
Signed-off-by: Deepak Kathayat <deepak.mk17@gmail.com>
---
block/qcow2.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/qcow2.h b/block/qcow2.h
index 0b0eac8..25663d4 100644
--- a/block/qcow2.h
+++ b/block/qcow2.h
@@ -413,7 +413,6 @@ static inline uint64_t l2meta_cow_end(QCowL2Meta *m)
+ (m->cow_end.nb_sectors << BDRV_SECTOR_BITS);
}
-// FIXME Need qcow2_ prefix to global functions
/* qcow2.c functions */
int qcow2_backing_read1(BlockDriverState *bs, QEMUIOVector *qiov,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] qcow2: Remove FIXME comment, already fixed
2014-03-24 6:06 [Qemu-devel] [PATCH] qcow2: Remove FIXME comment, already fixed Deepak Kathayat
@ 2014-03-24 15:08 ` Leandro Dorileo
2014-03-25 12:47 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Leandro Dorileo @ 2014-03-24 15:08 UTC (permalink / raw)
To: Deepak Kathayat; +Cc: qemu-trivial, qemu-devel, stefanha
On Mon, Mar 24, 2014 at 02:06:15PM +0800, Deepak Kathayat wrote:
>
> Signed-off-by: Deepak Kathayat <deepak.mk17@gmail.com>
Reviewed-by: Leandro Dorileo <l@dorileo.org>
> ---
> block/qcow2.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/block/qcow2.h b/block/qcow2.h
> index 0b0eac8..25663d4 100644
> --- a/block/qcow2.h
> +++ b/block/qcow2.h
> @@ -413,7 +413,6 @@ static inline uint64_t l2meta_cow_end(QCowL2Meta *m)
> + (m->cow_end.nb_sectors << BDRV_SECTOR_BITS);
> }
>
> -// FIXME Need qcow2_ prefix to global functions
>
> /* qcow2.c functions */
> int qcow2_backing_read1(BlockDriverState *bs, QEMUIOVector *qiov,
> --
> 1.7.9.5
>
>
--
Leandro Dorileo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] qcow2: Remove FIXME comment, already fixed
2014-03-24 6:06 [Qemu-devel] [PATCH] qcow2: Remove FIXME comment, already fixed Deepak Kathayat
2014-03-24 15:08 ` Leandro Dorileo
@ 2014-03-25 12:47 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2014-03-25 12:47 UTC (permalink / raw)
To: Deepak Kathayat; +Cc: qemu-trivial, qemu-devel, stefanha
On Mon, Mar 24, 2014 at 02:06:15PM +0800, Deepak Kathayat wrote:
>
> Signed-off-by: Deepak Kathayat <deepak.mk17@gmail.com>
> ---
> block/qcow2.h | 1 -
> 1 file changed, 1 deletion(-)
Thanks, applied to my block-next tree:
https://github.com/stefanha/qemu/commits/block-next
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-25 12:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-24 6:06 [Qemu-devel] [PATCH] qcow2: Remove FIXME comment, already fixed Deepak Kathayat
2014-03-24 15:08 ` Leandro Dorileo
2014-03-25 12:47 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).