From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44994)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <l@dorileo.org>) id 1WSXiG-0006Ky-Eu
	for qemu-devel@nongnu.org; Tue, 25 Mar 2014 16:12:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <l@dorileo.org>) id 1WSXiB-0006UD-IO
	for qemu-devel@nongnu.org; Tue, 25 Mar 2014 16:12:44 -0400
Received: from mail-ob0-f170.google.com ([209.85.214.170]:50428)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <l@dorileo.org>) id 1WSXiB-0006U4-DO
	for qemu-devel@nongnu.org; Tue, 25 Mar 2014 16:12:39 -0400
Received: by mail-ob0-f170.google.com with SMTP id uz6so1237756obc.29
	for <qemu-devel@nongnu.org>; Tue, 25 Mar 2014 13:12:38 -0700 (PDT)
Date: Tue, 25 Mar 2014 20:10:57 +0000
From: Leandro Dorileo <l@dorileo.org>
Message-ID: <20140325201057.GH29429@dorilex>
References: <1395396763-26081-1-git-send-email-cyliu@suse.com>
	<1395396763-26081-12-git-send-email-cyliu@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1395396763-26081-12-git-send-email-cyliu@suse.com>
Subject: Re: [Qemu-devel] [PATCH v23 11/32] qemu_opts_print: change fprintf
 stderr to printf
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Chunyan Liu <cyliu@suse.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com

On Fri, Mar 21, 2014 at 06:12:22PM +0800, Chunyan Liu wrote:
> Currently this function is not used anywhere. In later patches, it will
> replace print_option_parameters. print_option_parameters uses printf,
> to avoid print info changes after switching to QemuOpts, change
> qemu_opts_print from fprintf stderr to printf to keep consistent.
> 
> Signed-off-by: Chunyan Liu <cyliu@suse.com>
> ---
>  util/qemu-option.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/util/qemu-option.c b/util/qemu-option.c
> index e9802f3..a9c53cd 100644
> --- a/util/qemu-option.c
> +++ b/util/qemu-option.c
> @@ -1012,7 +1012,7 @@ void qemu_opts_print(QemuOpts *opts)
>  
>      if (desc[0].name == NULL) {
>          QTAILQ_FOREACH(opt, &opts->head, next) {
> -            fprintf(stderr, "%s=\"%s\" ", opt->name, opt->str);
> +            printf("%s=\"%s\" ", opt->name, opt->str);
>          }
>          return;
>      }
> @@ -1025,12 +1025,12 @@ void qemu_opts_print(QemuOpts *opts)
>              continue;
>          }
>          if (desc->type == QEMU_OPT_STRING) {
> -            fprintf(stderr, "%s='%s' ", desc->name, value);
> +            printf("%s='%s' ", desc->name, value);
>          } else {
> -            fprintf(stderr, "%s=%s ", desc->name, value);
> +            printf("%s=%s ", desc->name, value);
>          }
>      }
> -    fprintf(stderr, "\n");
> +    printf("\n");


This new line is breaking most of the io tests since it changes
the expected output.

Regards...

--
Leandro Dorileo

>  }
>  
>  static int opts_do_parse(QemuOpts *opts, const char *params,
> -- 
> 1.7.12.4
> 
>