From: Riku Voipio <riku.voipio@iki.fi>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: James Hogan <james.hogan@imgtec.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] linux-user: Correct DLINFO_ITEMS
Date: Wed, 26 Mar 2014 14:08:51 +0200 [thread overview]
Message-ID: <20140326120851.GA15164@afflict.kos.to> (raw)
In-Reply-To: <CAFEAcA-0oZxG9AW_6CrkjJTtzKYXhnxZ=6PSf6QfyybRQqmOCg@mail.gmail.com>
Hi,
On Tue, Mar 25, 2014 at 10:20:04PM +0000, Peter Maydell wrote:
> On 25 March 2014 21:47, James Hogan <james.hogan@imgtec.com> wrote:
> > Commit a07c67dfccb1 (Implement AT_CLKTCK.) back in March 2008 added a
> > new auxvec entry but didn't increment DLINFO_ITEMS, so it's been out of
> > sync ever since.
> >
> > Bump it up to 14 so that it matches the number of NEW_AUX_ENT's that
> > need to be counted in create_elf_tables().
>
> This code could clearly use at least an assert that we've not written more
> entries than we should, or ideally restructuring somehow so that we don't
> have to set DLINFO_ITEMS by hand in the first place...
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> for the immediate fix, though.
I've applied this and the other paches from you to my tree:
https://git.linaro.org/people/riku.voipio/qemu.git/shortlog/refs/heads/linux-user-for-upstream
I think others are ok to be applied post-2.0 release, but I'll
send this for 2.0
Riku
Riku
prev parent reply other threads:[~2014-03-26 12:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-25 21:47 [Qemu-devel] [PATCH] linux-user: Correct DLINFO_ITEMS James Hogan
2014-03-25 22:20 ` Peter Maydell
2014-03-25 23:40 ` James Hogan
2014-03-25 23:51 ` Peter Maydell
2014-03-26 0:27 ` James Hogan
2014-03-26 12:08 ` Riku Voipio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140326120851.GA15164@afflict.kos.to \
--to=riku.voipio@iki.fi \
--cc=james.hogan@imgtec.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).