From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51200)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nchip@afflict.kos.to>) id 1WSmdd-00043N-Ul
	for qemu-devel@nongnu.org; Wed, 26 Mar 2014 08:09:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <nchip@afflict.kos.to>) id 1WSmdZ-0004sp-IF
	for qemu-devel@nongnu.org; Wed, 26 Mar 2014 08:08:57 -0400
Received: from afflict.kos.to ([92.243.29.197]:57674)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nchip@afflict.kos.to>) id 1WSmdZ-0004sM-AQ
	for qemu-devel@nongnu.org; Wed, 26 Mar 2014 08:08:53 -0400
Date: Wed, 26 Mar 2014 14:08:51 +0200
From: Riku Voipio <riku.voipio@iki.fi>
Message-ID: <20140326120851.GA15164@afflict.kos.to>
References: <1395784048-28123-1-git-send-email-james.hogan@imgtec.com>
	<CAFEAcA-0oZxG9AW_6CrkjJTtzKYXhnxZ=6PSf6QfyybRQqmOCg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA-0oZxG9AW_6CrkjJTtzKYXhnxZ=6PSf6QfyybRQqmOCg@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] linux-user: Correct DLINFO_ITEMS
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: James Hogan <james.hogan@imgtec.com>, QEMU Developers <qemu-devel@nongnu.org>

Hi,

On Tue, Mar 25, 2014 at 10:20:04PM +0000, Peter Maydell wrote:
> On 25 March 2014 21:47, James Hogan <james.hogan@imgtec.com> wrote:
> > Commit a07c67dfccb1 (Implement AT_CLKTCK.) back in March 2008 added a
> > new auxvec entry but didn't increment DLINFO_ITEMS, so it's been out of
> > sync ever since.
> >
> > Bump it up to 14 so that it matches the number of NEW_AUX_ENT's that
> > need to be counted in create_elf_tables().
> 
> This code could clearly use at least an assert that we've not written more
> entries than we should, or ideally restructuring somehow so that we don't
> have to set DLINFO_ITEMS by hand in the first place...
 
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> for the immediate fix, though.

I've applied this and the other paches from you to my tree:

https://git.linaro.org/people/riku.voipio/qemu.git/shortlog/refs/heads/linux-user-for-upstream

I think others are ok to be applied post-2.0 release, but I'll
send this for 2.0

Riku

Riku