From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37482) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSndj-00022c-Tk for qemu-devel@nongnu.org; Wed, 26 Mar 2014 09:13:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WSndf-0001Lk-B0 for qemu-devel@nongnu.org; Wed, 26 Mar 2014 09:13:07 -0400 Received: from lputeaux-656-01-25-125.w80-12.abo.wanadoo.fr ([80.12.84.125]:56539 helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSndf-0001LL-4l for qemu-devel@nongnu.org; Wed, 26 Mar 2014 09:13:03 -0400 Date: Wed, 26 Mar 2014 14:13:00 +0100 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20140326131300.GA3860@irqsave.net> References: <1388704234-22498-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1388704234-22498-4-git-send-email-xiawenc@linux.vnet.ibm.com> <5318C354.6060706@redhat.com> <5329030F.5010401@gmail.com> <532B6BDE.9040705@redhat.com> <532F829E.8040903@gmail.com> <87zjkd5dxd.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87zjkd5dxd.fsf@blackfin.pond.sub.org> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC PATCH V2 3/5] qapi script: add event support by qapi-event.py List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: =?iso-8859-1?Q?Beno=EEt?= Canet , Wenchao Xia , qemu-devel@nongnu.org, mreitz@redhat.com, lcapitulino@redhat.com The Wednesday 26 Mar 2014 =C3=A0 13:42:38 (+0100), Markus Armbruster wrot= e : > Wenchao Xia writes: >=20 > > =E4=BA=8E 2014/3/21 6:29, Eric Blake =E5=86=99=E9=81=93: > >> On 03/18/2014 08:38 PM, Wenchao Xia wrote: > >>> =E4=BA=8E 2014/3/7 2:49, Eric Blake =E5=86=99=E9=81=93: > >>>> On 01/02/2014 04:10 PM, Wenchao Xia wrote: > >>>>> qapi-event.py will parse the schema and generate qapi-event.c, th= en > >>>>> the API in qapi-event.c can be used to handle event in qemu code. > >>>>> All API have prefix "qapi_event", all types have prefix "QAPIEven= t". > >>>>> Examples can be found in following patches. > >>>>> > >>>>> +for o, a in opts: > >>>>> + if o in ("-p", "--prefix"): > >>>>> + prefix =3D a > >>>>> + elif o in ("-o", "--output-dir"): > >>>>> + output_dir =3D a + "/" > >>>>> + elif o in ("-c", "--source"): > >>>>> + do_c =3D True > >>>>> + elif o in ("-h", "--header"): > >>>>> + do_h =3D True > >>>>> + elif o in ("-b", "--builtins"): > >>>>> + do_builtins =3D True > >>>> You may need to rebase this on top of other patches that refactor = the > >>>> qapi generators to track the input file, for improved error messag= es. > >>> It seems qapi-visit.py and qapi-types.py remains the same as abo= ve in > >>> upstream, which kind of change are your referring to? > >> Llu=C3=ADs' patch to use an explicit input file via a new -i option: > >> https://lists.gnu.org/archive/html/qemu-devel/2014-02/msg05220.html > >> > > I see, will adjust it. >=20 > Part of "[PATCH v4 0/3] qapi: Allow modularization of QAPI schema > files". There's also Beno=C3=AEt's "[PATCH 0/2] Create and include dir= ective > for QAPI JSON files"[*]. Beno=C3=AEt, care to explain how the two are > related? I don't see the relation excepted that my patch changes the various qapi-= generators to accept their input files as argv[1]. The purpose of my patch is to implement a directive to modularise the pse= udo JSON files we use. Lluis told me that he would not have the time to work on hi= s series until the end of the month so I picked up the ball. Best regards Beno=C3=AEt >=20 > Wenchao, please note "you *may* need to rebase". First patch in wins := ) >=20 > [*] https://lists.nongnu.org/archive/html/qemu-devel/2014-03/msg04412.h= tml