From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59023)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WT5LK-0000Wp-P5
	for qemu-devel@nongnu.org; Thu, 27 Mar 2014 04:07:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WT5LE-0003P8-QW
	for qemu-devel@nongnu.org; Thu, 27 Mar 2014 04:07:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:17807)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WT5LE-0003Ot-GN
	for qemu-devel@nongnu.org; Thu, 27 Mar 2014 04:07:12 -0400
Date: Thu, 27 Mar 2014 09:20:38 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140327072038.GA18249@redhat.com>
References: <1394624898-2730-1-git-send-email-dgilbert@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1394624898-2730-1-git-send-email-dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/1] configure time fix for thread naming
	on old glibc
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, jan.kiszka@siemens.com

On Wed, Mar 12, 2014 at 11:48:17AM +0000, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> 
> Peter was preferring configure time detection of pthread_setname_np
> to guard against my recent breaking of builds on old libc.
> 
> I've tested this on:
>    Fedora 20 - modern glibc - works as before
>    RHEL 5 - glibc 2.5:
>      [dgilbert@davidgil-rhel5 try]$ ./bin/qemu-system-x86_64 -nographic -name debug-threads=on
>      qemu: thread naming not supported on this host
> 
>    and checked a mingw windows cross build builds.
> 
> A check on SLES11 is probably worth a try if someone has one to hand.


I've applied this for 2.0, thanks!


> Dr. David Alan Gilbert (1):
>   Detect pthread_setname_np at configure time
> 
>  configure                | 28 ++++++++++++++++++++++++++++
>  util/qemu-thread-posix.c | 21 ++++++++++++++++++---
>  util/qemu-thread-win32.c |  2 ++
>  3 files changed, 48 insertions(+), 3 deletions(-)
> 
> -- 
> 1.8.5.3