From: Amos Kong <akong@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: armbru@redhat.com, libvirt-list@redhat.com,
qemu-devel@nongnu.org, anthony@codemonkey.ws, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH v4 for 2.0 0/3] ABI change: change group name of option table to match with option name
Date: Thu, 27 Mar 2014 21:03:00 +0800 [thread overview]
Message-ID: <20140327130300.GA16947@amosk.info> (raw)
In-Reply-To: <53341975.5090204@redhat.com>
On Thu, Mar 27, 2014 at 01:28:37PM +0100, Paolo Bonzini wrote:
> Il 27/03/2014 03:38, Amos Kong ha scritto:
> >This patchset changes group names of option tables to match with option name,
> >this breakes ABI, release note was updated.
> >
> >Amos Kong (3):
> > only add qemu_tpmdev_opts when CONFIG_TPM is defined
> > abort QEMU if group name in option table doesn't match with defined
> > option name
> > update names in option tables to match with actual command-line
> > spelling
> >
> > hw/acpi/core.c | 8 ++++----
> > hw/nvram/fw_cfg.c | 4 ++--
> > include/qemu/option.h | 2 +-
> > qemu-options.h | 12 ++++++++++++
> > util/qemu-config.c | 28 ++++++++++++++++++++++++++++
> > vl.c | 37 +++++++++++++------------------------
> > 6 files changed, 60 insertions(+), 31 deletions(-)
> >
>
> Patches 2 and 3 should be in the opposite order.
Right, I changed the order for testing, but didn't recover it back.
The subject also needs to be fixed to [PATCH v4 for 2.0 0/3]
> Paolo
--
Amos.
prev parent reply other threads:[~2014-03-27 13:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 2:38 [Qemu-devel] [PATCH 0/3] ABI change: change group name of option table to match with option name Amos Kong
2014-03-27 2:38 ` [Qemu-devel] [PATCH 1/3] only add qemu_tpmdev_opts when CONFIG_TPM is defined Amos Kong
2014-03-27 2:38 ` [Qemu-devel] [PATCH 2/3] abort QEMU if group name in option table doesn't match with defined option name Amos Kong
2014-03-27 2:38 ` [Qemu-devel] [PATCH 3/3] update names in option tables to match with actual command-line spelling Amos Kong
2014-03-27 12:28 ` [Qemu-devel] [PATCH 0/3] ABI change: change group name of option table to match with option name Paolo Bonzini
2014-03-27 13:03 ` Amos Kong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140327130300.GA16947@amosk.info \
--to=akong@redhat.com \
--cc=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=libvirt-list@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).