From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55350)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1WT9xi-0003wh-0e
	for qemu-devel@nongnu.org; Thu, 27 Mar 2014 09:03:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1WT9xc-00007l-29
	for qemu-devel@nongnu.org; Thu, 27 Mar 2014 09:03:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:12034)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1WT9xb-00006e-QC
	for qemu-devel@nongnu.org; Thu, 27 Mar 2014 09:03:07 -0400
Date: Thu, 27 Mar 2014 21:03:00 +0800
From: Amos Kong <akong@redhat.com>
Message-ID: <20140327130300.GA16947@amosk.info>
References: <1395887892-25910-1-git-send-email-akong@redhat.com>
	<53341975.5090204@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <53341975.5090204@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 for 2.0 0/3] ABI change: change group
 name of option table to match with option name
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: armbru@redhat.com, libvirt-list@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, afaerber@suse.de

On Thu, Mar 27, 2014 at 01:28:37PM +0100, Paolo Bonzini wrote:
> Il 27/03/2014 03:38, Amos Kong ha scritto:
> >This patchset changes group names of option tables to match with option name,
> >this breakes ABI, release note was updated.
> >
> >Amos Kong (3):
> >  only add qemu_tpmdev_opts when CONFIG_TPM is defined
> >  abort QEMU if group name in option table doesn't match with defined
> >    option name
> >  update names in option tables to match with actual command-line
> >    spelling
> >
> > hw/acpi/core.c        |  8 ++++----
> > hw/nvram/fw_cfg.c     |  4 ++--
> > include/qemu/option.h |  2 +-
> > qemu-options.h        | 12 ++++++++++++
> > util/qemu-config.c    | 28 ++++++++++++++++++++++++++++
> > vl.c                  | 37 +++++++++++++------------------------
> > 6 files changed, 60 insertions(+), 31 deletions(-)
> >
> 
> Patches 2 and 3 should be in the opposite order.
 
Right, I changed the order for testing, but didn't recover it back.
The subject also needs to be fixed to [PATCH v4 for 2.0 0/3]


> Paolo

-- 
			Amos.