From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43185) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTB1O-0004Oh-M0 for qemu-devel@nongnu.org; Thu, 27 Mar 2014 10:11:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WTB1H-0007ra-53 for qemu-devel@nongnu.org; Thu, 27 Mar 2014 10:11:06 -0400 Received: from indium.canonical.com ([91.189.90.7]:37015) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTB1G-0007rL-ST for qemu-devel@nongnu.org; Thu, 27 Mar 2014 10:10:59 -0400 Received: from loganberry.canonical.com ([91.189.90.37]) by indium.canonical.com with esmtp (Exim 4.76 #1 (Debian)) id 1WTB1G-0005r5-3D for ; Thu, 27 Mar 2014 14:10:58 +0000 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id 075792E80C7 for ; Thu, 27 Mar 2014 14:10:58 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Date: Thu, 27 Mar 2014 14:03:22 -0000 From: Serge Hallyn <1297651@bugs.launchpad.net> Sender: bounces@canonical.com References: <20140326064510.5518.72436.malonedeb@chaenomeles.canonical.com> <20140327052251.9642.54769.malone@soybean.canonical.com> Message-Id: <20140327140322.GA4262@sergelap> Errors-To: bounces@canonical.com Subject: Re: [Qemu-devel] [Bug 1297651] Re: KVM create a win7 guest with Qemu, it boots up fail Reply-To: Bug 1297651 <1297651@bugs.launchpad.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Quoting Robert Hu (robert.hu@intel.com): > on latest commit (db237e33), this bug doesn't exit. Sorry, I don't see this commit in qemu.git? -- = You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1297651 Title: KVM create a win7 guest with Qemu, it boots up fail Status in QEMU: New Bug description: Environment: ------------ Host OS (ia32/ia32e/IA64):ia32e Guest OS (ia32/ia32e/IA64):ia32e Guest OS Type (Linux/Windows):Windows kvm.git Commit:94b3ffcd41a90d2cb0b32ca23aa58a01111d5dc0 qemu-kvm Commit:839a5547574e57cce62f49bfc50fe1f04b00589a Host Kernel Version:3.14.0-rc3 Hardware:Romley_EP, Ivytown_EP, HSW_EP = Bug detailed description: -------------------------- when create a win7 guest, the guest boot up fail. note: = 1. when create win2000, winxp, win2k3, win2k8, guest, the guest boot up f= ail. 2. when create win8, win8.1, win2012 guest, the guest boot up fine. = Reproduce steps: ---------------- 1.create guest qemu-system-x86_64 -enable-kvm -m 1024 -smp 2 -net none -hda /root/win7.q= cow = Current result: ---------------- win7 guest boot up fail Expected result: ---------------- win7 guest boot up fine Basic root-causing log: ---------------------- This should be a qemu bug kvm + qemu =3D result 94b3ffcd + 839a5547 =3D bad 94b3ffcd + 3a87f8b6 =3D good the first bad commit is: commit 9bcc80cd71892df42605e0c097d85c0237ff45d1 Author: Laszlo Ersek Date: Mon Mar 17 17:05:16 2014 +0100 i386/acpi-build: allow more than 255 elements in CPON The build_ssdt() function builds a number of AML objects that are rel= ated to CPU hotplug, and whose IDs form a contiguous sequence of APIC IDs. (APIC IDs are in fact discontiguous, but this is the traditional interface: build a contiguous sequence from zero up that covers all possible APIC IDs.) These objects are: - a Processor() object for each VCPU, - a NTFY method, with one branch for each VCPU, - a CPON package with one element (hotplug status byte) for each VCPU. The build_ssdt() function currently limits the *count* of processor objects, and NTFY branches, and CPON elements, in 0xFF (see the assig= nment to "acpi_cpus"). This allows for an inclusive APIC ID range of [0..25= 4]. This is incorrect, because the highest APIC ID that we otherwise allo= w a VCPU to take is 255. In order to extend the maximum count to 256, and the traversed APIC ID range correspondingly to [0..255]: - the Processor() objects need no change, - the NTFY method also needs no change, - the CPON package must be updated, because it is defined with a DefPackage, and the number of elements in such a package can be at = most 255. We pick a DefVarPackage instead. We replace the Op byte, and the encoding of the number of elements. Compare: DefPackage :=3D PackageOp PkgLength NumElements PackageElem= entList DefVarPackage :=3D VarPackageOp PkgLength VarNumElements PackageElem= entList PackageOp :=3D 0x12 VarPackageOp :=3D 0x13 NumElements :=3D ByteData VarNumElements :=3D TermArg =3D> Integer The build_append_int() function implements precisely the following Te= rmArg encodings (a subset of what the ACPI spec describes): TermArg :=3D DataObject DataObject :=3D ComputationalData ComputationalData :=3D ConstObj | ByteConst | WordConst | DWordCo= nst directly encoded in the function, with build_append_byte(): ConstObj :=3D ZeroOp | OneOp ZeroOp :=3D 0x00 OneOp :=3D 0x01 call to build_append_value(..., 1): ByteConst :=3D BytePrefix ByteData BytePrefix :=3D 0x0A ByteData :=3D 0x00 - 0xFF call to build_append_value(..., 2): WordConst :=3D WordPrefix WordData WordPrefix :=3D 0x0B WordData :=3D ByteData[0:7] ByteData[8:15] call to build_append_value(..., 4): DWordConst :=3D DWordPrefix DWordData DWordPrefix :=3D 0x0C DWordData :=3D WordData[0:15] WordData[16:31] Signed-off-by: Laszlo Ersek Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1297651/+subscriptions