From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45965)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WTCsF-0008Pk-G0
	for qemu-devel@nongnu.org; Thu, 27 Mar 2014 12:09:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WTCs6-0001D8-MZ
	for qemu-devel@nongnu.org; Thu, 27 Mar 2014 12:09:47 -0400
Received: from mail-bk0-x233.google.com ([2a00:1450:4008:c01::233]:47735)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WTCs6-0001Cv-Fe
	for qemu-devel@nongnu.org; Thu, 27 Mar 2014 12:09:38 -0400
Received: by mail-bk0-f51.google.com with SMTP id 6so819591bkj.10
	for <qemu-devel@nongnu.org>; Thu, 27 Mar 2014 09:09:37 -0700 (PDT)
Date: Thu, 27 Mar 2014 17:09:34 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20140327160934.GC2441@stefanha-thinkpad.redhat.com>
References: <1395911388-31027-1-git-send-email-famz@redhat.com>
	<1395911388-31027-3-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1395911388-31027-3-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 2/9] qmp: Add dirty-bitmap-add and
 dirty-bitmap-remove
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Benoit Canet <benoit@irqsave.net>

On Thu, Mar 27, 2014 at 05:09:41PM +0800, Fam Zheng wrote:
> +    if (has_granularity) {
> +        if (granularity & (granularity - 1)) {
> +            error_setg(errp, "Granularity must be power of 2");
> +            return;
> +        }
> +    } else {
> +        granularity = 65536;
> +    }

util/hbitmap.c has:
assert(granularity >= 0 && granularity < 64);

Please make sure the argument is checked before we pass it down.  We
should never hit an assertion failure due to bad inputs.

Stefan