From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57558) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTGrC-00027a-Kk for qemu-devel@nongnu.org; Thu, 27 Mar 2014 16:25:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WTGr7-0002y4-LA for qemu-devel@nongnu.org; Thu, 27 Mar 2014 16:24:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39218) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTGr7-0002xv-CG for qemu-devel@nongnu.org; Thu, 27 Mar 2014 16:24:53 -0400 Date: Thu, 27 Mar 2014 16:24:50 -0400 From: Luiz Capitulino Message-ID: <20140327162450.0e46b45f@redhat.com> In-Reply-To: <1394363777-14132-5-git-send-email-kroosec@gmail.com> References: <1394363777-14132-1-git-send-email-kroosec@gmail.com> <1394363777-14132-5-git-send-email-kroosec@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/7] monitor: Add cpu index argument completion. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hani Benhabiles Cc: kwolf@redhat.com, imammedo@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On Sun, 9 Mar 2014 12:16:14 +0100 Hani Benhabiles wrote: > Signed-off-by: Hani Benhabiles Honest question: is this one really worth it? Aren't we just auto-completing a single integer? > --- > hmp-commands.hx | 1 + > hmp.h | 1 + > monitor.c | 24 ++++++++++++++++++++++++ > 3 files changed, 26 insertions(+) > > diff --git a/hmp-commands.hx b/hmp-commands.hx > index a411d4f..813c0fb 100644 > --- a/hmp-commands.hx > +++ b/hmp-commands.hx > @@ -690,6 +690,7 @@ ETEXI > .params = "index", > .help = "set the default CPU", > .mhandler.cmd = hmp_cpu, > + .command_completion = cpu_completion, > }, > > STEXI > diff --git a/hmp.h b/hmp.h > index dc03984..59a60ed 100644 > --- a/hmp.h > +++ b/hmp.h > @@ -98,6 +98,7 @@ void object_add_completion(Monitor *mon, int nb_args, const char *str); > void object_del_completion(Monitor *mon, int nb_args, const char *str); > void chardev_add_completion(Monitor *mon, int nb_args, const char *str); > void chardev_remove_completion(Monitor *mon, int nb_args, const char *str); > +void cpu_completion(Monitor *mon, int nb_args, const char *str); > > > #endif > diff --git a/monitor.c b/monitor.c > index 73442c6..43aab76 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -4429,6 +4429,30 @@ void object_del_completion(Monitor *mon, int nb_args, const char *str) > qapi_free_ObjectPropertyInfoList(start); > } > > +void cpu_completion(Monitor *mon, int nb_args, const char *str) > +{ > + CpuInfoList *cpu_list, *start; > + size_t len; > + > + if (nb_args != 2) { > + return; > + } > + len = strlen(str); > + readline_set_completion_index(mon->rs, len); > + > + start = cpu_list = qmp_query_cpus(NULL); > + while (cpu_list) { > + char name[16]; > + snprintf(name, sizeof(name), "%" PRId64, cpu_list->value->CPU); > + > + if (!strncmp(str, name, len)) { > + readline_add_completion(mon->rs, name); > + } > + cpu_list = cpu_list->next; > + } > + qapi_free_CpuInfoList(start); > +} > + > static void monitor_find_completion_by_table(Monitor *mon, > const mon_cmd_t *cmd_table, > char **args,