From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58268)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1WTGsa-0004xL-Lf
	for qemu-devel@nongnu.org; Thu, 27 Mar 2014 16:26:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1WTGsU-0003rH-N4
	for qemu-devel@nongnu.org; Thu, 27 Mar 2014 16:26:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:64809)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1WTGsU-0003rD-FV
	for qemu-devel@nongnu.org; Thu, 27 Mar 2014 16:26:18 -0400
Date: Thu, 27 Mar 2014 16:26:15 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20140327162615.04aa25d4@redhat.com>
In-Reply-To: <1394363777-14132-1-git-send-email-kroosec@gmail.com>
References: <1394363777-14132-1-git-send-email-kroosec@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/7] monitor: Completion support for
	various commands.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hani Benhabiles <kroosec@gmail.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, stefanha@redhat.com, imammedo@redhat.com

On Sun,  9 Mar 2014 12:16:10 +0100
Hani Benhabiles <kroosec@gmail.com> wrote:

> This patch series adds a new callback to mon_cmd_t which will make adding
> completion support for more commands cleaner.
> 
> It then adds full or partial arguments completion for 7 different hmp commands.

The general approach seems OK to me, but I could use some help to review
the entire series.

Stefan, could you please review the set_link(), netdev_add/del() changes?

> 
> Hani Benhabiles (7):
>   monitor: Add command_completion callback to mon_cmd_t.
>   monitor: Add chardev-remove id argument completion.
>   monitor: Add chardev-add backend argument completion.
>   monitor: Add cpu index argument completion.
>   monitor: Add set_link arguments completion.
>   monitor: Add netdev_add type argument completion.
>   monitor: Add netdev_del id argument completion.
> 
>  hmp-commands.hx |  14 +++-
>  hmp.h           |  11 +++
>  monitor.c       | 213 +++++++++++++++++++++++++++++++++++++++++++++++++-------
>  3 files changed, 211 insertions(+), 27 deletions(-)
>