From: Hani Benhabiles <kroosec@gmail.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: kwolf@redhat.com, imammedo@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 4/7] monitor: Add cpu index argument completion.
Date: Thu, 27 Mar 2014 22:51:13 +0100 [thread overview]
Message-ID: <20140327215113.GC22714@Inspiron-3521> (raw)
In-Reply-To: <20140327162450.0e46b45f@redhat.com>
On Thu, Mar 27, 2014 at 04:24:50PM -0400, Luiz Capitulino wrote:
> On Sun, 9 Mar 2014 12:16:14 +0100
> Hani Benhabiles <kroosec@gmail.com> wrote:
>
> > Signed-off-by: Hani Benhabiles <hani@linux.com>
>
> Honest question: is this one really worth it? Aren't we just
> auto-completing a single integer?
It could for example serve for fast discovery, without having to check
"info cpus" before hand.
No strong opinion about it, so feel free to take it or not. I did it because
well, it was trivial enough and took too few efforts to leave behind.
next prev parent reply other threads:[~2014-03-27 21:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-09 11:16 [Qemu-devel] [PATCH 0/7] monitor: Completion support for various commands Hani Benhabiles
2014-03-09 11:16 ` [Qemu-devel] [PATCH 1/7] monitor: Add command_completion callback to mon_cmd_t Hani Benhabiles
2014-03-27 20:21 ` Luiz Capitulino
2014-03-27 21:55 ` Hani Benhabiles
2014-03-28 13:10 ` Luiz Capitulino
2014-03-09 11:16 ` [Qemu-devel] [PATCH 2/7] monitor: Add chardev-remove id argument completion Hani Benhabiles
2014-03-09 11:16 ` [Qemu-devel] [PATCH 3/7] monitor: Add chardev-add backend " Hani Benhabiles
2014-03-09 11:16 ` [Qemu-devel] [PATCH 4/7] monitor: Add cpu index " Hani Benhabiles
2014-03-27 20:24 ` Luiz Capitulino
2014-03-27 21:51 ` Hani Benhabiles [this message]
2014-03-09 11:16 ` [Qemu-devel] [PATCH 5/7] monitor: Add set_link arguments completion Hani Benhabiles
2014-03-09 11:16 ` [Qemu-devel] [PATCH 6/7] monitor: Add netdev_add type argument completion Hani Benhabiles
2014-03-09 11:16 ` [Qemu-devel] [PATCH 7/7] monitor: Add netdev_del id " Hani Benhabiles
2014-03-10 14:44 ` [Qemu-devel] [PATCH 0/7] monitor: Completion support for various commands Luiz Capitulino
2014-03-11 7:18 ` Hani Benhabiles
2014-03-27 20:26 ` Luiz Capitulino
2014-03-27 21:47 ` Hani Benhabiles
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140327215113.GC22714@Inspiron-3521 \
--to=kroosec@gmail.com \
--cc=imammedo@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).