From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55444) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTICs-00034t-QF for qemu-devel@nongnu.org; Thu, 27 Mar 2014 17:51:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WTICn-0000r1-07 for qemu-devel@nongnu.org; Thu, 27 Mar 2014 17:51:26 -0400 Received: from mail-ee0-x230.google.com ([2a00:1450:4013:c00::230]:51661) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTICm-0000pN-Pg for qemu-devel@nongnu.org; Thu, 27 Mar 2014 17:51:20 -0400 Received: by mail-ee0-f48.google.com with SMTP id b57so3375006eek.35 for ; Thu, 27 Mar 2014 14:51:19 -0700 (PDT) Date: Thu, 27 Mar 2014 22:51:13 +0100 From: Hani Benhabiles Message-ID: <20140327215113.GC22714@Inspiron-3521> References: <1394363777-14132-1-git-send-email-kroosec@gmail.com> <1394363777-14132-5-git-send-email-kroosec@gmail.com> <20140327162450.0e46b45f@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140327162450.0e46b45f@redhat.com> Subject: Re: [Qemu-devel] [PATCH 4/7] monitor: Add cpu index argument completion. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: kwolf@redhat.com, imammedo@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On Thu, Mar 27, 2014 at 04:24:50PM -0400, Luiz Capitulino wrote: > On Sun, 9 Mar 2014 12:16:14 +0100 > Hani Benhabiles wrote: > > > Signed-off-by: Hani Benhabiles > > Honest question: is this one really worth it? Aren't we just > auto-completing a single integer? It could for example serve for fast discovery, without having to check "info cpus" before hand. No strong opinion about it, so feel free to take it or not. I did it because well, it was trivial enough and took too few efforts to leave behind.