From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46356)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <l@dorileo.org>) id 1WTVkU-0000Uw-7W
	for qemu-devel@nongnu.org; Fri, 28 Mar 2014 08:19:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <l@dorileo.org>) id 1WTVkO-0006PC-Vq
	for qemu-devel@nongnu.org; Fri, 28 Mar 2014 08:19:02 -0400
Received: from mail-vc0-f181.google.com ([209.85.220.181]:35945)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <l@dorileo.org>) id 1WTVkO-0006P3-S6
	for qemu-devel@nongnu.org; Fri, 28 Mar 2014 08:18:56 -0400
Received: by mail-vc0-f181.google.com with SMTP id id10so5689422vcb.26
	for <qemu-devel@nongnu.org>; Fri, 28 Mar 2014 05:18:56 -0700 (PDT)
Date: Fri, 28 Mar 2014 09:19:00 -0300
From: Leandro Dorileo <l@dorileo.org>
Message-ID: <20140328121834.GA970@dorilex-lnv.MultilaserAP>
References: <1395844634-11729-1-git-send-email-alex.bennee@linaro.org>
	<1395844634-11729-3-git-send-email-alex.bennee@linaro.org>
	<20140326184927.GB23230@dorilex> <87siq4ynba.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <87siq4ynba.fsf@linaro.org>
Subject: Re: [Qemu-devel] [RFC PATCH 2/4] qemu-log: support simple pid
 substitution in logfile
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex =?iso-8859-1?Q?Benn=E9e?= <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org

On Thu, Mar 27, 2014 at 09:59:21AM +0000, Alex Bennée wrote:
> 
> Leandro Dorileo <l@dorileo.org> writes:
> 
> > On Wed, Mar 26, 2014 at 02:37:12PM +0000, alex.bennee@linaro.org wrote:
> >> From: Alex Bennée <alex.bennee@linaro.org>
> >> 
> >> When debugging stuff that occurs over several forks it would be useful
> >> not to keep overwriting the one logfile you've set-up. This allows a
> >> simple %d to be included once in the logfile parameter which is
> >> substituted with getpid().
> <snip>
> >
> > Looks good to me.
> 
> Is that a Reviewed-by? If you include a Reviewed-by tag it makes it
> easier to copy and paste into the commit for the next iteration.

Sure, you can add

Reviewed-by: Leandro Dorileo <l@dorileo.org>

-- 
Leandro Dorileo