From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54009)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WUWOF-00055w-Gj
	for qemu-devel@nongnu.org; Mon, 31 Mar 2014 03:12:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WUWO9-00052U-BB
	for qemu-devel@nongnu.org; Mon, 31 Mar 2014 03:12:15 -0400
Date: Mon, 31 Mar 2014 09:12:06 +0200
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20140331071206.GC22888@stefanha-thinkpad.redhat.com>
References: <1395835569-21193-1-git-send-email-stefanha@redhat.com>
	<1395835569-21193-40-git-send-email-stefanha@redhat.com>
	<53360452.6090805@redhat.com>
	<20140329002626.GL21833@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140329002626.GL21833@localhost.localdomain>
Subject: Re: [Qemu-devel] [PATCH for-2.0 39/47] block: vdi bounds check
 qemu-io tests
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jeff Cody <jcody@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-stable@nongnu.org, pmatouse@redhat.com, qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>

On Fri, Mar 28, 2014 at 08:26:26PM -0400, Jeff Cody wrote:
> On Sat, Mar 29, 2014 at 12:22:58AM +0100, Max Reitz wrote:
> > On 26.03.2014 13:06, Stefan Hajnoczi wrote:
> > >+echo "Test 7: Block Size != 1MB; too large test (1MB + 1)"
> > >+poke_file "$TEST_IMG" "$bs_offset" "\x00\x00\x11\x00"  # invalid (too large)
> > 
> > 0x110000 is not 1 MB + 1.
> >
> 
> Indeed it is not.  I changed the test, but forgot to update the
> comment.
> 
> I already submitted a v2; Stefan, do you want me to submit a v3 with a
> comment change, or do you want to fix up the comment when applying the
> patch (note you'd need to change the .out file as well)?

I'll take v2 and fix up the comment and .out file.

Stefan