From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38188)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WUiYM-0004aa-Rd
	for qemu-devel@nongnu.org; Mon, 31 Mar 2014 16:11:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WUiYH-0004BY-LJ
	for qemu-devel@nongnu.org; Mon, 31 Mar 2014 16:11:30 -0400
Date: Mon, 31 Mar 2014 22:38:12 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140331193812.GA12398@redhat.com>
References: <1396275242-10810-1-git-send-email-mst@redhat.com>
	<1396275242-10810-29-git-send-email-mst@redhat.com>
	<20140331163343.GF11125@work-vm>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140331163343.GF11125@work-vm>
Subject: Re: [Qemu-devel] [PATCH v4 28/30] vmxnet3: validate interrupt
 indices read on migration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: Anthony Liguori <anthony@codemonkey.ws>, qemu-stable@nongnu.org, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Dmitry Fleytman <dmitry@daynix.com>, Paolo Bonzini <pbonzini@redhat.com>, mdroth@linux.vnet.ibm.com

On Mon, Mar 31, 2014 at 05:33:44PM +0100, Dr. David Alan Gilbert wrote:
> * Michael S. Tsirkin (mst@redhat.com) wrote:
> > From: Dmitry Fleytman <dmitry@daynix.com>
> > 
> > CVE-2013-4544
> > 
> > Signed-off-by: Dmitry Fleytman <dmitry@daynix.com>
> > Reported-by: Michael S. Tsirkin <mst@redhat.com>
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >  hw/net/vmxnet3.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
> > index a4b5c11..8c6df05 100644
> > --- a/hw/net/vmxnet3.c
> > +++ b/hw/net/vmxnet3.c
> > @@ -2374,6 +2374,8 @@ static int vmxnet3_post_load(void *opaque, int version_id)
> >          }
> >      }
> >  
> > +    vmxnet3_validate_interrupts(s);
> > +
> 
> When you repost to fix the other stuff, why not merge this with what
> is currently #30.
> 
> Dave

I generally try to avoid making random changes to other's patches,
unless absolutely necessary.
Dmitry?

> --
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK