From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36561)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kroosec@gmail.com>) id 1WUkPz-0007nh-B8
	for qemu-devel@nongnu.org; Mon, 31 Mar 2014 18:11:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kroosec@gmail.com>) id 1WUkPq-0008If-AQ
	for qemu-devel@nongnu.org; Mon, 31 Mar 2014 18:10:59 -0400
Received: from mail-we0-x22f.google.com ([2a00:1450:400c:c03::22f]:59659)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kroosec@gmail.com>) id 1WUkPp-0008IW-B7
	for qemu-devel@nongnu.org; Mon, 31 Mar 2014 18:10:49 -0400
Received: by mail-we0-f175.google.com with SMTP id q58so5333007wes.20
	for <qemu-devel@nongnu.org>; Mon, 31 Mar 2014 15:10:48 -0700 (PDT)
Date: Mon, 31 Mar 2014 23:10:37 +0100
From: Hani Benhabiles <kroosec@gmail.com>
Message-ID: <20140331221037.GA30421@Inspiron-3521>
References: <1396187381-31618-1-git-send-email-kroosec@gmail.com>
	<1396246349.3108.1.camel@nilsson.home.kraxel.org>
	<87bnwmleo2.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87bnwmleo2.fsf@blackfin.pond.sub.org>
Subject: Re: [Qemu-devel] [PATCH] input: mouse_set should check input device
 type.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, aliguori@amazon.com, qemu-devel@nongnu.org

On Mon, Mar 31, 2014 at 02:45:49PM +0200, Markus Armbruster wrote:
> Gerd Hoffmann <kraxel@redhat.com> writes:
> 
> >> +        if (!(s->handler->mask & (INPUT_EVENT_MASK_REL |
> >> +                                  INPUT_EVENT_MASK_ABS))) {
> >> +            monitor_printf(mon, "Input device '%s' is not a mouse",
> >> +                           s->handler->name);
> >
> > That should be error_report (I think, Markus?).
> 
> Yes, please.  Same for the "Mouse at given index not found\n" message
> further down.  Note that error_report() does *not* want \n.

Ok, thanks.

I just followed the other monitor_printf() usage for consistency. v2 sent.

> 
> >
> > Otherwise the patch is fine.
> >
> > cheers,
> >   Gerd