From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41514)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WV0Mw-0007EZ-Ow
	for qemu-devel@nongnu.org; Tue, 01 Apr 2014 11:13:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WV0Mq-0001PA-Hy
	for qemu-devel@nongnu.org; Tue, 01 Apr 2014 11:12:54 -0400
Date: Tue, 1 Apr 2014 18:12:52 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140401151252.GA9260@redhat.com>
References: <1396275242-10810-1-git-send-email-mst@redhat.com>
	<1396275242-10810-13-git-send-email-mst@redhat.com>
	<CAFEAcA8fsRikwSMqsEHEzkcM9N-ao+icntkRnk7nrqWEX=uNew@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA8fsRikwSMqsEHEzkcM9N-ao+icntkRnk7nrqWEX=uNew@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v4 12/30] vmstate: fix buffer overflow in
 target-arm/machine.c
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>, Juan Quintela <quintela@redhat.com>, Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-stable <qemu-stable@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>, Anthony Liguori <anthony@codemonkey.ws>, Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>, Dave Gilbert <dgilbert@redhat.com>

On Mon, Mar 31, 2014 at 04:40:41PM +0100, Peter Maydell wrote:
> On 31 March 2014 15:16, Michael S. Tsirkin <mst@redhat.com> wrote:
> > CVE-2013-4531
> >
> > cpreg_vmstate_indexes is a VARRAY_INT32. A negative value for
> > cpreg_vmstate_array_len will cause a buffer overflow.
> >
> > VMSTATE_INT32_LE was supposed to protect against this
> > but doesn't because it doesn't validate that input is
> > non-negative.
> >
> > Fix this macro to valide the value appropriately.
> >
> > The only other user of VMSTATE_INT32_LE doesn't
> > ever use negative numbers so it doesn't care.
> 
> This fixes the bug, but it's rather unintuitive semantics
> for an INT32_LE not to simply do a signed comparison...
> Maybe rename the macro?
> 
> thanks
> -- PMM

Sure. I'll do it in a separate patch though.