From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37036)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WV23y-00048A-Gd
	for qemu-devel@nongnu.org; Tue, 01 Apr 2014 13:01:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WV23s-0004Mh-DL
	for qemu-devel@nongnu.org; Tue, 01 Apr 2014 13:01:26 -0400
Date: Tue, 1 Apr 2014 19:01:15 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20140401170115.GM5878@noname.redhat.com>
References: <1395835569-21193-1-git-send-email-stefanha@redhat.com>
	<1395835569-21193-9-git-send-email-stefanha@redhat.com>
	<5333317A.30604@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5333317A.30604@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.0 08/47] qemu-iotests: Support for
 bochs format
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: pmatouse@redhat.com, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, qemu-stable@nongnu.org

Am 26.03.2014 um 20:58 hat Max Reitz geschrieben:
> On 26.03.2014 13:05, Stefan Hajnoczi wrote:
> >From: Kevin Wolf <kwolf@redhat.com>
> >
> >Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> >Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> >---
> >  tests/qemu-iotests/078                           |  53 +++++++++++++++++++++++
> >  tests/qemu-iotests/078.out                       |   6 +++
> >  tests/qemu-iotests/common                        |   7 +++
> >  tests/qemu-iotests/group                         |   1 +
> >  tests/qemu-iotests/sample_images/empty.bochs.bz2 | Bin 0 -> 118 bytes
> >  5 files changed, 67 insertions(+)
> >  create mode 100755 tests/qemu-iotests/078
> >  create mode 100644 tests/qemu-iotests/078.out
> >  create mode 100644 tests/qemu-iotests/sample_images/empty.bochs.bz2
> >
> >diff --git a/tests/qemu-iotests/078 b/tests/qemu-iotests/078
> >new file mode 100755
> >index 0000000..f55f46d
> >--- /dev/null
> >+++ b/tests/qemu-iotests/078
> >@@ -0,0 +1,53 @@
> >+#!/bin/bash
> >+#
> >+# bochs format input validation tests
> >+#
> >+# Copyright (C) 2013 Red Hat, Inc.
> >+#
> >+# This program is free software; you can redistribute it and/or modify
> >+# it under the terms of the GNU General Public License as published by
> >+# the Free Software Foundation; either version 2 of the License, or
> >+# (at your option) any later version.
> >+#
> >+# This program is distributed in the hope that it will be useful,
> >+# but WITHOUT ANY WARRANTY; without even the implied warranty of
> >+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> >+# GNU General Public License for more details.
> >+#
> >+# You should have received a copy of the GNU General Public License
> >+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> >+#
> >+
> >+# creator
> >+owner=kwolf@redhat.com
> >+
> >+seq=`basename $0`
> >+echo "QA output created by $seq"
> >+
> >+here=`pwd`
> >+tmp=/tmp/$$
> >+status=1	# failure is the default!
> >+
> >+_cleanup()
> >+{
> >+	_cleanup_test_img
> >+}
> >+trap "_cleanup; exit \$status" 0 1 2 3 15
> >+
> >+# get standard environment, filters and checks
> >+. ./common.rc
> >+. ./common.filter
> >+
> >+_supported_fmt bochs
> >+_supported_proto generic
> >+_supported_os Linux
> >+
> >+echo
> >+echo "== Read from a valid image =="
> >+_use_sample_img empty.bochs.bz2
> >+{ $QEMU_IO -c "read 0 512" $TEST_IMG; } 2>&1 | _filter_qemu_io | _filter_testdir
> 
> Is there a special reason for the braces here?

Yes, it makes bash print things like "Segmentation fault", which it
otherwise wouldn't print when the output is redirected.

Kevin