From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH v2 3/7] hw/net/stellaris_enet: Rewrite tx fifo handling code
Date: Wed, 2 Apr 2014 16:28:43 +0100 [thread overview]
Message-ID: <20140402152842.GJ2586@work-vm> (raw)
In-Reply-To: <1396390495-8908-4-git-send-email-peter.maydell@linaro.org>
* Peter Maydell (peter.maydell@linaro.org) wrote:
> The datasheet is clear that the frame length written to the DATA
> register is actually stored in the TX FIFO; this means we don't
> need to keep both tx_frame_len and tx_fifo_len state separately.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> - register_savevm(dev, "stellaris_enet", -1, 1,
> + register_savevm(dev, "stellaris_enet", -1, 2,
> stellaris_enet_save, stellaris_enet_load, s);
> return 0;
Note that as well as inc'ing that you would have to change the
if (version_id != 1)
in stellaris_enet_load (if you weren't about to scrap the load/save
code anyway).
Dave
> }
> --
> 1.9.0
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2014-04-02 15:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-01 22:14 [Qemu-devel] [PATCH v2 0/7] stellaris_enet: overhaul tx/rx, convert to vmstate Peter Maydell
2014-04-01 22:14 ` [Qemu-devel] [PATCH v2 1/7] hw/net/stellaris_enet: Restructure tx_fifo code to avoid buffer overrun Peter Maydell
2014-04-01 22:14 ` [Qemu-devel] [PATCH v2 2/7] hw/net/stellaris_enet: Correct handling of packet padding Peter Maydell
2014-04-01 22:14 ` [Qemu-devel] [PATCH v2 3/7] hw/net/stellaris_enet: Rewrite tx fifo handling code Peter Maydell
2014-04-02 15:28 ` Dr. David Alan Gilbert [this message]
2014-04-01 22:14 ` [Qemu-devel] [PATCH v2 4/7] hw/net/stellaris_enet: Correctly implement the TR and THR registers Peter Maydell
2014-04-02 15:33 ` Dr. David Alan Gilbert
2014-04-01 22:14 ` [Qemu-devel] [PATCH v2 5/7] hw/net/stellaris_enet: Fix debug format strings Peter Maydell
2014-04-01 22:14 ` [Qemu-devel] [PATCH v2 6/7] hw/net/stellaris_enet: Get rid of rx_fifo pointer Peter Maydell
2014-04-02 16:19 ` Dr. David Alan Gilbert
2014-04-01 22:14 ` [Qemu-devel] [PATCH v2 7/7] hw/net/stellaris_enet: Convert to vmstate Peter Maydell
2014-04-02 16:37 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140402152842.GJ2586@work-vm \
--to=dgilbert@redhat.com \
--cc=mst@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).