From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46899) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVN62-0007oJ-7u for qemu-devel@nongnu.org; Wed, 02 Apr 2014 11:29:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WVN5v-0003YK-E6 for qemu-devel@nongnu.org; Wed, 02 Apr 2014 11:28:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63682) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVN5u-0003XW-UI for qemu-devel@nongnu.org; Wed, 02 Apr 2014 11:28:51 -0400 Date: Wed, 2 Apr 2014 16:28:43 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20140402152842.GJ2586@work-vm> References: <1396390495-8908-1-git-send-email-peter.maydell@linaro.org> <1396390495-8908-4-git-send-email-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1396390495-8908-4-git-send-email-peter.maydell@linaro.org> Subject: Re: [Qemu-devel] [PATCH v2 3/7] hw/net/stellaris_enet: Rewrite tx fifo handling code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: "Michael S. Tsirkin" , qemu-devel@nongnu.org, patches@linaro.org * Peter Maydell (peter.maydell@linaro.org) wrote: > The datasheet is clear that the frame length written to the DATA > register is actually stored in the TX FIFO; this means we don't > need to keep both tx_frame_len and tx_fifo_len state separately. > > Signed-off-by: Peter Maydell > Reviewed-by: Dr. David Alan Gilbert > --- > - register_savevm(dev, "stellaris_enet", -1, 1, > + register_savevm(dev, "stellaris_enet", -1, 2, > stellaris_enet_save, stellaris_enet_load, s); > return 0; Note that as well as inc'ing that you would have to change the if (version_id != 1) in stellaris_enet_load (if you weren't about to scrap the load/save code anyway). Dave > } > -- > 1.9.0 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK