From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Ed Maste <emaste@freebsd.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] qemu-thread-posix: Fix build against older glibc version
Date: Wed, 2 Apr 2014 16:38:40 +0100 [thread overview]
Message-ID: <20140402153839.GL2586@work-vm> (raw)
In-Reply-To: <CAPyFy2Btq8qNDEEZ=gsS8b7MwEf7OoOxqxjb=a32oR5u+aunXw@mail.gmail.com>
* Ed Maste (emaste@freebsd.org) wrote:
> On 11 March 2014 12:13, Dr. David Alan Gilbert <dgilbert@redhat.com> wrote:
>
> > Except pthread_setname_np is not portable and was previously
> > ifdef'd _GNU_SOURCE anyway, and the parameters on other OSs
> > maybe different (freebsd has got a 3rd parameter for no
> > apparent reason).
>
> No, glibc's arguments are identical to FreeBSD's. The difference is
> that it's pthread_set_name_np (with an extra underscore).
>
> FreeBSD: void pthread_set_name_np(pthread_t, const char *);
> glibc: int pthread_setname_np(pthread_t, const char *);
> NetBSD: int pthread_setname_np(pthread_t, const char *, void *);
> Darwin: pthread_setname_np(const char *);
Ah, apologies - I got the wrong *BSD for the 3rd argument stuff.
Anyway, feel free to add your favorite OS to the configure check/use.
Dave
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2014-04-02 15:39 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-09 19:19 [Qemu-devel] [PULL v3 00/14] acpi,pc,pci,virtio,memory bug fixes Michael S. Tsirkin
2014-03-09 19:19 ` [Qemu-devel] [PULL v3 01/14] acpi-build: append description for non-hotplug Michael S. Tsirkin
2014-03-09 19:19 ` [Qemu-devel] [PULL v3 02/14] acpi-test-data: update expected files Michael S. Tsirkin
2014-03-09 19:19 ` [Qemu-devel] [PULL v3 03/14] virtio-net: remove function calls from assert Michael S. Tsirkin
2014-03-09 19:19 ` [Qemu-devel] [PULL v3 04/14] memory_region_present: return false if address is not found in child MemoryRegion Michael S. Tsirkin
2014-03-09 19:19 ` [Qemu-devel] [PULL v3 05/14] PCIE: fix regression with coldplugged multifunction device Michael S. Tsirkin
2014-03-09 19:19 ` [Qemu-devel] [PULL v3 06/14] Rework --name to use QemuOpts Michael S. Tsirkin
2014-03-09 19:19 ` [Qemu-devel] [PULL v3 07/14] Add 'debug-threads' suboption to --name Michael S. Tsirkin
2014-03-09 19:20 ` [Qemu-devel] [PULL v3 08/14] Add a 'name' parameter to qemu_thread_create Michael S. Tsirkin
2014-03-11 15:31 ` Jan Kiszka
2014-03-11 15:49 ` [Qemu-devel] [PATCH] qemu-thread-posix: Fix build against older glibc version Jan Kiszka
2014-03-11 16:10 ` Peter Maydell
2014-03-11 16:13 ` Dr. David Alan Gilbert
2014-03-11 16:20 ` Peter Maydell
2014-03-11 16:36 ` Dr. David Alan Gilbert
2014-03-11 17:51 ` Peter Maydell
2014-03-11 18:39 ` Michael S. Tsirkin
2014-03-11 19:46 ` Dr. David Alan Gilbert
2014-03-11 19:53 ` Peter Maydell
2014-03-11 20:03 ` Michael S. Tsirkin
2014-03-11 20:27 ` Peter Maydell
2014-03-11 20:35 ` Michael S. Tsirkin
2014-03-11 20:39 ` Eric Blake
2014-03-11 20:04 ` Dr. David Alan Gilbert
2014-04-02 14:18 ` Ed Maste
2014-04-02 15:38 ` Dr. David Alan Gilbert [this message]
2014-03-11 18:08 ` Dr. David Alan Gilbert
2014-03-11 19:02 ` Peter Maydell
2014-03-11 15:55 ` [Qemu-devel] [PULL v3 08/14] Add a 'name' parameter to qemu_thread_create Dr. David Alan Gilbert
2014-03-09 19:20 ` [Qemu-devel] [PULL v3 09/14] MAINTAINERS: drop an out of date address Michael S. Tsirkin
2014-03-09 19:20 ` [Qemu-devel] [PULL v3 10/14] acpi-test: retain both asl and aml files on failure Michael S. Tsirkin
2014-03-09 19:20 ` [Qemu-devel] [PULL v3 11/14] acpi-test: issue errors instead of warnings when possible Michael S. Tsirkin
2014-03-09 19:20 ` [Qemu-devel] [PULL v3 12/14] pam: partly fix write-only mode Michael S. Tsirkin
2014-03-09 19:20 ` [Qemu-devel] [PULL v3 13/14] pckbd: return 'keyboard enabled' on read input port command Michael S. Tsirkin
2014-03-09 19:20 ` [Qemu-devel] [PULL v3 14/14] qemu: x86: ignore ioapic polarity Michael S. Tsirkin
2014-03-10 15:38 ` [Qemu-devel] [PULL v3 00/14] acpi, pc, pci, virtio, memory bug fixes Peter Maydell
2014-03-10 19:05 ` Michael S. Tsirkin
2014-03-11 10:55 ` Peter Maydell
2014-03-11 11:22 ` Michael S. Tsirkin
2014-03-11 11:32 ` Peter Maydell
2014-03-11 11:49 ` Michael S. Tsirkin
2014-03-11 12:09 ` Peter Maydell
2014-03-11 12:22 ` Michael S. Tsirkin
2014-03-11 12:31 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140402153839.GL2586@work-vm \
--to=dgilbert@redhat.com \
--cc=emaste@freebsd.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).