From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49077)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1WVNFm-0006vC-7k
	for qemu-devel@nongnu.org; Wed, 02 Apr 2014 11:39:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1WVNFc-0007CX-Gl
	for qemu-devel@nongnu.org; Wed, 02 Apr 2014 11:39:02 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44056)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1WVNFc-0007C3-83
	for qemu-devel@nongnu.org; Wed, 02 Apr 2014 11:38:52 -0400
Date: Wed, 2 Apr 2014 16:38:40 +0100
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Message-ID: <20140402153839.GL2586@work-vm>
References: <1394392713-31471-1-git-send-email-mst@redhat.com>
	<1394392713-31471-9-git-send-email-mst@redhat.com>
	<531F2C52.50401@siemens.com> <531F3083.9090304@siemens.com>
	<CAFEAcA-O1OsAABYTNeeXQZgtDkErEih6rDm=chVRFXnzx5j=sg@mail.gmail.com>
	<20140311161301.GG2450@work-vm>
	<CAPyFy2Btq8qNDEEZ=gsS8b7MwEf7OoOxqxjb=a32oR5u+aunXw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAPyFy2Btq8qNDEEZ=gsS8b7MwEf7OoOxqxjb=a32oR5u+aunXw@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] qemu-thread-posix: Fix build against older
 glibc version
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ed Maste <emaste@freebsd.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>

* Ed Maste (emaste@freebsd.org) wrote:
> On 11 March 2014 12:13, Dr. David Alan Gilbert <dgilbert@redhat.com> wrote:
> 
> > Except pthread_setname_np is not portable and was previously
> > ifdef'd _GNU_SOURCE anyway, and the parameters on other OSs
> > maybe different (freebsd has got a 3rd parameter for no
> > apparent reason).
> 
> No, glibc's arguments are identical to FreeBSD's.  The difference is
> that it's pthread_set_name_np (with an extra underscore).
> 
> FreeBSD: void pthread_set_name_np(pthread_t, const char *);
> glibc: int pthread_setname_np(pthread_t, const char *);
> NetBSD: int pthread_setname_np(pthread_t, const char *, void *);
> Darwin: pthread_setname_np(const char *);

Ah, apologies - I got the wrong *BSD for the 3rd argument stuff.
Anyway, feel free to add your favorite OS to the configure check/use.

Dave
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK