From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WW37w-0000k9-VZ for qemu-devel@nongnu.org; Fri, 04 Apr 2014 08:21:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WW37q-00088v-RE for qemu-devel@nongnu.org; Fri, 04 Apr 2014 08:21:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10156) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WW37q-00088p-JB for qemu-devel@nongnu.org; Fri, 04 Apr 2014 08:21:38 -0400 Date: Fri, 4 Apr 2014 14:21:23 +0200 From: Stefan Hajnoczi Message-ID: <20140404122123.GA12760@stefanha-thinkpad.redhat.com> References: <1396612409-17932-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1396612409-17932-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH for-2.0] iscsi: Don't set error if already set in iscsi_do_inquiry List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Kevin Wolf , Paolo Bonzini , Peter Lieven , qemu-devel@nongnu.org On Fri, Apr 04, 2014 at 07:53:29PM +0800, Fam Zheng wrote: > This eliminates the possible assertion failure in error_setg(). > > Signed-off-by: Fam Zheng > --- > block/iscsi.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Stefan Hajnoczi