From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54216)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WWjDo-0007cs-IO
	for qemu-devel@nongnu.org; Sun, 06 Apr 2014 05:18:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WWjDi-0004nL-Dl
	for qemu-devel@nongnu.org; Sun, 06 Apr 2014 05:18:36 -0400
Received: from mx1.redhat.com ([209.132.183.28]:24959)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WWjDi-0004nE-5M
	for qemu-devel@nongnu.org; Sun, 06 Apr 2014 05:18:30 -0400
Date: Sun, 6 Apr 2014 12:18:50 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140406091850.GB5116@redhat.com>
References: <1396618620-27823-1-git-send-email-imammedo@redhat.com>
	<1396618620-27823-31-git-send-email-imammedo@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1396618620-27823-31-git-send-email-imammedo@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 30/35] pc: ACPI BIOS: name CPU hotplug
	ACPI0004 device
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>
Cc: peter.maydell@linaro.org, aik@ozlabs.ru, hutao@cn.fujitsu.com, mjt@tls.msk.ru, qemu-devel@nongnu.org, lcapitulino@redhat.com, kraxel@redhat.com, akong@redhat.com, quintela@redhat.com, armbru@redhat.com, aliguori@amazon.com, jan.kiszka@siemens.com, lersek@redhat.com, ehabkost@redhat.com, marcel.a@redhat.com, stefanha@redhat.com, chegu_vinod@hp.com, rth@twiddle.net, kwolf@redhat.com, s.priebe@profihost.ag, mreitz@redhat.com, vasilis.liaskovitis@profitbricks.com, pbonzini@redhat.com, afaerber@suse.de

On Fri, Apr 04, 2014 at 03:36:55PM +0200, Igor Mammedov wrote:
> Following patches will add another ACPI0004 device
> to the same scope, and that will make Windows BSOD
> because it thinks that the second ACPI0004 device
> is duplicate.
> Adding to device unique _UID, fixes issue and allows
> Windows to distinguish devices with the same _HID
> 
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>

Weren't we going to rename ACPI0004 to PNP0C02 or something?
I remember it creates problems for older guests.

> ---
>  hw/i386/acpi-dsdt-cpu-hotplug.dsl | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/i386/acpi-dsdt-cpu-hotplug.dsl b/hw/i386/acpi-dsdt-cpu-hotplug.dsl
> index dee4843..81fb876 100644
> --- a/hw/i386/acpi-dsdt-cpu-hotplug.dsl
> +++ b/hw/i386/acpi-dsdt-cpu-hotplug.dsl
> @@ -94,6 +94,7 @@ Scope(\_SB) {
>  
>      Device(CPU_HOTPLUG_RESOURCE_DEVICE) {
>          Name(_HID, "ACPI0004")
> +        Name(_UID, "CPU hotplug resources")
>  
>          Name(_CRS, ResourceTemplate() {
>              IO(Decode16, CPU_STATUS_BASE, CPU_STATUS_BASE, 0, CPU_STATUS_LEN)
> -- 
> 1.9.0