From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WX5Nc-0005y2-9T for qemu-devel@nongnu.org; Mon, 07 Apr 2014 04:58:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WX5NV-0005Gu-Vd for qemu-devel@nongnu.org; Mon, 07 Apr 2014 04:58:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10824) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WX5NV-0005Gb-KW for qemu-devel@nongnu.org; Mon, 07 Apr 2014 04:58:05 -0400 Date: Mon, 7 Apr 2014 10:57:02 +0200 From: Igor Mammedov Message-ID: <20140407105702.2562dfb1@nial.usersys.redhat.com> In-Reply-To: <1396776125-5419-1-git-send-email-mst@redhat.com> References: <1396776125-5419-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-2.0] dsdt: tweak ACPI ID for hotplug resource device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, Anthony Liguori On Sun, 6 Apr 2014 12:47:37 +0300 "Michael S. Tsirkin" wrote: > ACPI0004 seems too new: > Windows XP complains about an unrecognized device. > This is a regression since 1.7. > Use PNP0A06 instead - Generic Container Device. >=20 > Signed-off-by: Michael S. Tsirkin > --- >=20 > Note: Igor has RFC patches to use PNP0C02 under PCI0, > but that's not ready for 2.0. > Igor, could you comment on whether PNP0C02 is preferable for > some OS-es? >=20 > For PNP0A06 ACPI spec says: > PNP0A06 > Generic Container Device. This device behaves exactly the same as the > PNP0A05 device. > This was originally known as Extended I/O Bus. This ID should only be > used for containers > that do not produce resources for consumption by child devices. Any > system resources > claimed by a PNP0A06 device=E2=80=99s _CRS object must be consumed by= the > container itself. >=20 > PNP0C02 is not in ACPI spec. It does appear in MicroSoft legacy PNP ID > document: > PNP0C02 General ID for reserving resources required by Plug a= nd > Play motherboard registers. (Not specific to a particular device.) >=20 > Thoughts? >=20 > hw/i386/acpi-dsdt-cpu-hotplug.dsl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/hw/i386/acpi-dsdt-cpu-hotplug.dsl b/hw/i386/acpi-dsdt-cpu-ho= tplug.dsl > index dee4843..34aab5a 100644 > --- a/hw/i386/acpi-dsdt-cpu-hotplug.dsl > +++ b/hw/i386/acpi-dsdt-cpu-hotplug.dsl > @@ -93,7 +93,7 @@ Scope(\_SB) { > } > =20 > Device(CPU_HOTPLUG_RESOURCE_DEVICE) { > - Name(_HID, "ACPI0004") > + Name(_HID, EisaId("PNP0A06")) > =20 > Name(_CRS, ResourceTemplate() { > IO(Decode16, CPU_STATUS_BASE, CPU_STATUS_BASE, 0, CPU_STATUS= _LEN) Reviewed-By: Igor Mammedov