From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: seabios@seabios.org, qemu-devel@nongnu.org,
Marcel Apfelbaum <marcel.a@redhat.com>
Subject: Re: [Qemu-devel] [SeaBIOS] [PATCH] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached
Date: Mon, 7 Apr 2014 15:11:36 +0300 [thread overview]
Message-ID: <20140407121136.GC16369@redhat.com> (raw)
In-Reply-To: <1396872101.5001.64.camel@nilsson.home.kraxel.org>
On Mon, Apr 07, 2014 at 02:01:41PM +0200, Gerd Hoffmann wrote:
> On Mo, 2014-04-07 at 13:59 +0300, Marcel Apfelbaum wrote:
> > If a pci-2-pci bridge supports hot-plug functionality but there are no devices
> > connected to it, reserve IO/mem in order to be able to attach devices
> > later. Do not waste space, use minimum allowed.
>
> Makes sense.
>
> > + u8 shpc_cap = pci_find_capability(s->bus_dev, PCI_CAP_ID_SHPC);
>
> Should we also check for hotplug-capable pci express ports while being
> at it?
>
> cheers,
> Gerd
>
Can be a separate patch?
next prev parent reply other threads:[~2014-04-07 12:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-07 10:59 [Qemu-devel] [SeaBIOS] [PATCH] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached Marcel Apfelbaum
2014-04-07 12:01 ` Gerd Hoffmann
2014-04-07 12:11 ` Michael S. Tsirkin [this message]
2014-04-07 12:18 ` Marcel Apfelbaum
2014-04-07 12:15 ` Michael S. Tsirkin
2014-04-07 12:44 ` Gerd Hoffmann
2014-04-07 12:51 ` Marcel Apfelbaum
2014-04-07 13:34 ` Michael S. Tsirkin
2014-04-07 13:51 ` Marcel Apfelbaum
2014-04-07 13:55 ` Marcel Apfelbaum
2014-04-07 14:09 ` Michael S. Tsirkin
2014-04-07 14:16 ` Marcel Apfelbaum
2014-04-07 16:22 ` Michael S. Tsirkin
2014-04-08 6:05 ` Gerd Hoffmann
2014-04-08 8:54 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140407121136.GC16369@redhat.com \
--to=mst@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcel.a@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).