From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59450)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WX8OF-0006wt-UK
	for qemu-devel@nongnu.org; Mon, 07 Apr 2014 08:11:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WX8O9-00051r-Oz
	for qemu-devel@nongnu.org; Mon, 07 Apr 2014 08:11:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:29741)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WX8O9-00051n-Ge
	for qemu-devel@nongnu.org; Mon, 07 Apr 2014 08:10:57 -0400
Date: Mon, 7 Apr 2014 15:11:36 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140407121136.GC16369@redhat.com>
References: <1396868342-12005-1-git-send-email-marcel.a@redhat.com>
	<1396872101.5001.64.camel@nilsson.home.kraxel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1396872101.5001.64.camel@nilsson.home.kraxel.org>
Subject: Re: [Qemu-devel] [SeaBIOS] [PATCH] hw/pci: reserve IO and mem for
 pci-2-pci bridges with no devices attached
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: seabios@seabios.org, qemu-devel@nongnu.org, Marcel Apfelbaum <marcel.a@redhat.com>

On Mon, Apr 07, 2014 at 02:01:41PM +0200, Gerd Hoffmann wrote:
> On Mo, 2014-04-07 at 13:59 +0300, Marcel Apfelbaum wrote:
> > If a pci-2-pci bridge supports hot-plug functionality but there are no devices
> > connected to it, reserve IO/mem in order to be able to attach devices
> > later. Do not waste space, use minimum allowed.
> 
> Makes sense.
> 
> > +        u8 shpc_cap = pci_find_capability(s->bus_dev, PCI_CAP_ID_SHPC);
> 
> Should we also check for hotplug-capable pci express ports while being
> at it?
> 
> cheers,
>   Gerd
> 

Can be a separate patch?