From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42812)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kevin@koconnor.net>) id 1WXEjO-0005Ca-FF
	for qemu-devel@nongnu.org; Mon, 07 Apr 2014 14:57:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kevin@koconnor.net>) id 1WXEjF-0003VX-PP
	for qemu-devel@nongnu.org; Mon, 07 Apr 2014 14:57:18 -0400
Received: from mail-qc0-f178.google.com ([209.85.216.178]:54686)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kevin@koconnor.net>) id 1WXEjF-0003Uz-MZ
	for qemu-devel@nongnu.org; Mon, 07 Apr 2014 14:57:09 -0400
Received: by mail-qc0-f178.google.com with SMTP id i8so6982929qcq.9
	for <qemu-devel@nongnu.org>; Mon, 07 Apr 2014 11:57:09 -0700 (PDT)
Date: Mon, 7 Apr 2014 14:57:08 -0400
From: Kevin O'Connor <kevin@koconnor.net>
Message-ID: <20140407185708.GA10352@morn.localdomain>
References: <20140401202832.GA24065@morn.localdomain>
	<1396451097.31715.20.camel@nilsson.home.kraxel.org>
	<20140405003410.GA13086@morn.localdomain>
	<20140405011513.GB31429@foober.ini.cmu.edu>
	<20140405022632.GA21769@morn.localdomain>
	<1396854596.5001.17.camel@nilsson.home.kraxel.org>
	<20140407141435.GA22185@morn.localdomain>
	<20140407144953.GG1602@ERROL.INI.CMU.EDU>
	<20140407152344.GA26674@morn.localdomain>
	<20140407180520.GI1602@ERROL.INI.CMU.EDU>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140407180520.GI1602@ERROL.INI.CMU.EDU>
Subject: Re: [Qemu-devel] E820 (Re: [v4 PATCH 00/12] SMBIOS: build full
 tables in QEMU)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Gabriel L. Somlo" <gsomlo@gmail.com>
Cc: seabios@seabios.org, Laszlo Ersek <lersek@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org

On Mon, Apr 07, 2014 at 02:05:21PM -0400, Gabriel L. Somlo wrote:
> On Mon, Apr 07, 2014 at 11:23:44AM -0400, Kevin O'Connor wrote:
> > So, I'm suggesting QEMU produce two new fw_cfg files: an anchor file
> > with the valid anchor table (the address pointer can be just set to
> > zero), and an smbios table file with the complete set of smbios tables
> > formatted according to the smbios spec.  SeaBIOS can then use the
> > existence of one of these new files to determine if it should deploy
> > (and optionally modify) them or if it should use the old smbios
> > generation code.
> 
> Oh, OK. Right now we have (in qemu):
> 
> #define SMBIOS_FIELD_ENTRY 0
> #define SMBIOS_TABLE_ENTRY 1
> 
> I will be adding (actually, migrating to):
> 
> #define SMBIOS_ANCHOR_ENTRY 2 /* for the smbios entry point table */
> #define SMBIOS_FULLTABLE_ENTRY 3 /* for the blob containing all types */

No - don't do that.  Lets leave the existing smbios fw_cfg entry
(0x8001) unchanged.  Instead, introduce two new fw_cfg files using the
fw_cfg_add_file() interface (eg, "etc/smbios/smbios-anchor" and
"etc/smbios/smbios-tables").

[...]
> I can add such a structure for the anchor/entrypoint table and for the
> full blob-of-tables payload, in which I can tell you how big type 0 is,
> so the BIOS (SeaBIOS/TianoCore) side surgery can be made that much
> easier...

It's trivial for the firmware to calculate this on its own, so I
recommend just putting the anchor table and main tables unmodified in
their respective fw_cfg files.

-Kevin