From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55661)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1WXtQ2-0006ty-3h
	for qemu-devel@nongnu.org; Wed, 09 Apr 2014 10:24:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1WXtPu-00083M-8y
	for qemu-devel@nongnu.org; Wed, 09 Apr 2014 10:24:02 -0400
Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:49912)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1WXtIW-0005XU-1E
	for qemu-devel@nongnu.org; Wed, 09 Apr 2014 10:16:16 -0400
Received: from /spool/local
	by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <cornelia.huck@de.ibm.com>;
	Wed, 9 Apr 2014 15:16:14 +0100
Received: from b06cxnps3074.portsmouth.uk.ibm.com
	(d06relay09.portsmouth.uk.ibm.com [9.149.109.194])
	by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id E00282190063
	for <qemu-devel@nongnu.org>; Wed,  9 Apr 2014 15:16:06 +0100 (BST)
Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com
	[9.149.37.213])
	by b06cxnps3074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id s39EG5Nh2294164
	for <qemu-devel@nongnu.org>; Wed, 9 Apr 2014 14:16:05 GMT
Received: from d06av03.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id s39EGB9D029845
	for <qemu-devel@nongnu.org>; Wed, 9 Apr 2014 08:16:12 -0600
Date: Wed, 9 Apr 2014 16:16:09 +0200
From: Cornelia Huck <cornelia.huck@de.ibm.com>
Message-ID: <20140409161609.7810fa91.cornelia.huck@de.ibm.com>
In-Reply-To: <5345521F.20402@suse.de>
References: <1397043298-25755-1-git-send-email-cornelia.huck@de.ibm.com>
	<1397043298-25755-3-git-send-email-cornelia.huck@de.ibm.com>
	<5345521F.20402@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 2/5] kvm: add kvm_enable_cap_{vm,vcpu}
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: gleb@kernel.org, borntraeger@de.ibm.com, qemu-devel@nongnu.org, pbonzini@redhat.com

On Wed, 09 Apr 2014 15:58:55 +0200
Alexander Graf <agraf@suse.de> wrote:

> 
> On 09.04.14 13:34, Cornelia Huck wrote:
> > Provide helper functions for enabling capabilities (on a vcpu and on a vm).
> >
> > Reviewed-by: Thomas Huth <thuth@linux.vnet.ibm.com>
> > Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> 
> I think it makes sense to convert all ENABLE_CAP callers of the code 
> base to this helper as well. Once you do that, you'll realize that we 
> may want to have additional argument parameters ;).

OK, I'll do the additional conversions as a follow-up, so I can add a
good interface here :)