From: "Daniel P. Berrange" <berrange@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Hong-Hua.Yin@freescale.com" <Hong-Hua.Yin@freescale.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Li Zhang <zhlcindy@linux.vnet.ibm.com>,
"agraf@suse.de" <agraf@suse.de>,
"qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
"david@gibson.dropbear.id.au" <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms
Date: Thu, 10 Apr 2014 10:24:37 +0100 [thread overview]
Message-ID: <20140410092437.GA7746@redhat.com> (raw)
In-Reply-To: <531735C3.3010203@redhat.com>
On Wed, Mar 05, 2014 at 03:33:39PM +0100, Paolo Bonzini wrote:
> Il 05/03/2014 15:21, Daniel P. Berrange ha scritto:
> >>alpha/typhoon.c: b = pci_register_bus(dev, "pci",
> >>mips/gt64xxx_pci.c: phb->bus = pci_register_bus(dev, "pci",
> >>pci-host/apb.c: phb->bus = pci_register_bus(DEVICE(phb), "pci",
> >>pci-host/bonito.c: phb->bus = pci_register_bus(DEVICE(dev), "pci",
> >>sh4/sh_pci.c: phb->bus = pci_register_bus(DEVICE(dev), "pci",
> >>pci-host/versatile.c: pci_bus_new_inplace(&s->pci_bus, sizeof(s->pci_bus), DEVICE(obj), "pci",
> >>
> >>plus pseries which has its own rules because it supports multiple PCI
> >>host bridges, but probably can also be changed from "pci" to NULL.
> >
> >I'm not sure I understand the effect of changing 'pci' to NULL in this
> >code, from libvirt's POV. Would using NULL mean we can rely on using
> >"pci.0" as the default PCI bus name or not ?
>
> Yes. But the next bus that the user creates (e.g. from a PCI bridge
> without an "id") would be "pci.1" instead of having a duplicate
> "pci.0"). Needs a bit more testing of course.
What's the status of this ? I see the patch merged which only changes
the bus name for ppc64 spapr-pci board
commit 1b8601b0ea0b91467561e0bbddd52a833e4b2b1a
Author: Alexey Kardashevskiy <aik@ozlabs.ru>
Date: Thu Mar 6 14:11:00 2014 +1100
spapr-pci: Change the default PCI bus naming
but AFAICT nothing got merged to change this for all the other boards as
discussed here :-( This is painful for libvirt since we have todo even
more hacks triggered off machine names now, instead of being able to
rely on pci.0 naming as we hoped.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
next prev parent reply other threads:[~2014-04-10 9:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 10:42 [Qemu-devel] QEMU: PCI bus name on PowerPC platforms Hong-Hua.Yin
2014-03-05 11:43 ` Alexey Kardashevskiy
2014-03-05 13:35 ` Paolo Bonzini
2014-03-05 13:40 ` Daniel P. Berrange
2014-03-05 14:12 ` Paolo Bonzini
2014-03-05 14:21 ` Daniel P. Berrange
2014-03-05 14:33 ` Paolo Bonzini
2014-03-05 14:40 ` Daniel P. Berrange
2014-04-10 9:24 ` Daniel P. Berrange [this message]
2014-04-11 11:40 ` Alexey Kardashevskiy
2014-04-11 12:27 ` Eric Blake
2014-04-11 12:29 ` Alexander Graf
2014-03-05 14:35 ` Andreas Färber
2014-03-05 14:38 ` Andreas Färber
2014-03-05 14:44 ` Paolo Bonzini
2014-03-05 15:15 ` Alexey Kardashevskiy
2014-03-06 2:25 ` Hong-Hua.Yin
2014-03-06 7:04 ` Hong-Hua.Yin
2014-03-06 7:07 ` Alexey Kardashevskiy
2014-03-06 7:21 ` Hong-Hua.Yin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140410092437.GA7746@redhat.com \
--to=berrange@redhat.com \
--cc=Hong-Hua.Yin@freescale.com \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=david@gibson.dropbear.id.au \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=zhlcindy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).