From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33579) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYHDY-0006Hg-Cr for qemu-devel@nongnu.org; Thu, 10 Apr 2014 11:48:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WYHDS-0002I2-7K for qemu-devel@nongnu.org; Thu, 10 Apr 2014 11:48:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53749) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYHDR-0002Hk-Uv for qemu-devel@nongnu.org; Thu, 10 Apr 2014 11:48:38 -0400 Date: Thu, 10 Apr 2014 18:49:19 +0300 From: "Michael S. Tsirkin" Message-ID: <20140410154919.GI21110@redhat.com> References: <1397136581-10500-1-git-send-email-marcel.a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1397136581-10500-1-git-send-email-marcel.a@redhat.com> Subject: Re: [Qemu-devel] [SeaBIOS] [PATCH V3 0/2] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum Cc: kevin@koconnor.net, seabios@seabios.org, qemu-devel@nongnu.org, kraxel@redhat.com On Thu, Apr 10, 2014 at 04:29:39PM +0300, Marcel Apfelbaum wrote: > v2 -> v3: > - Addressed Michael S. Tsirkin's comments: > - I/O and Prefetchable Memory are optional. Do not allocate ranges > if they are not implemented (2/2). > - Note that 2/2 patch can be seen as a separate fix. However, it > is related to ranges reservation. > > v1 -> v2: > - Thanks Gerd Hoffmann for the review. > - Addressed Michael S. Tsirkin's comments: > - Limit capabilities query to 256 iterations, to make sure we > don't get into an infinite loop with a broken device. > An additional possible enhancement would be to avoid allocating for devices that are behind a non IO forwarding bridge. Can be a patch on top. > If a pci-2-pci bridge supports hot-plug functionality but there are no devices > connected to it, reserve IO/mem in order to be able to attach devices > later. Do not waste space, use minimum allowed. > > Marcel Apfelbaum (2): > hw/pci: reserve IO and mem for pci-2-pci bridges with no devices > attached > hw/pci: check if pci2pci bridges implement optional limit registers > > src/fw/pciinit.c | 12 +++++----- > src/hw/pci.c | 67 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > src/hw/pci.h | 10 +++++++++ > 3 files changed, 82 insertions(+), 7 deletions(-) > > -- > 1.8.3.1