* [Qemu-devel] [PATCH] iscsi: Remember to set ret for iscsi_open in error case
@ 2014-04-10 1:33 Fam Zheng
2014-04-10 11:11 ` Kevin Wolf
0 siblings, 1 reply; 4+ messages in thread
From: Fam Zheng @ 2014-04-10 1:33 UTC (permalink / raw)
To: qemu-devel; +Cc: Kevin Wolf, Peter Lieven, Stefan Hajnoczi
Signed-off-by: Fam Zheng <famz@redhat.com>
---
block/iscsi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/iscsi.c b/block/iscsi.c
index 64a509f..f425573 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -1233,6 +1233,7 @@ static int iscsi_open(BlockDriverState *bs, QDict *options, int flags,
iscsi_readcapacity_sync(iscsilun, &local_err);
if (local_err != NULL) {
error_propagate(errp, local_err);
+ ret = -EINVAL;
goto out;
}
bs->total_sectors = sector_lun2qemu(iscsilun->num_blocks, iscsilun);
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] iscsi: Remember to set ret for iscsi_open in error case
2014-04-10 1:33 [Qemu-devel] [PATCH] iscsi: Remember to set ret for iscsi_open in error case Fam Zheng
@ 2014-04-10 11:11 ` Kevin Wolf
2014-04-11 5:29 ` Fam Zheng
0 siblings, 1 reply; 4+ messages in thread
From: Kevin Wolf @ 2014-04-10 11:11 UTC (permalink / raw)
To: Fam Zheng; +Cc: Peter Lieven, qemu-devel, Stefan Hajnoczi
Am 10.04.2014 um 03:33 hat Fam Zheng geschrieben:
> Signed-off-by: Fam Zheng <famz@redhat.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] iscsi: Remember to set ret for iscsi_open in error case
2014-04-10 11:11 ` Kevin Wolf
@ 2014-04-11 5:29 ` Fam Zheng
2014-04-11 12:51 ` Kevin Wolf
0 siblings, 1 reply; 4+ messages in thread
From: Fam Zheng @ 2014-04-11 5:29 UTC (permalink / raw)
To: Kevin Wolf; +Cc: Peter Lieven, qemu-devel, Stefan Hajnoczi
On Thu, 04/10 13:11, Kevin Wolf wrote:
> Am 10.04.2014 um 03:33 hat Fam Zheng geschrieben:
> > Signed-off-by: Fam Zheng <famz@redhat.com>
>
> Thanks, applied to the block branch.
>
Is this going into 2.0?
Thanks,
Fam
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] iscsi: Remember to set ret for iscsi_open in error case
2014-04-11 5:29 ` Fam Zheng
@ 2014-04-11 12:51 ` Kevin Wolf
0 siblings, 0 replies; 4+ messages in thread
From: Kevin Wolf @ 2014-04-11 12:51 UTC (permalink / raw)
To: Fam Zheng; +Cc: Peter Lieven, qemu-devel, Stefan Hajnoczi
Am 11.04.2014 um 07:29 hat Fam Zheng geschrieben:
> On Thu, 04/10 13:11, Kevin Wolf wrote:
> > Am 10.04.2014 um 03:33 hat Fam Zheng geschrieben:
> > > Signed-off-by: Fam Zheng <famz@redhat.com>
> >
> > Thanks, applied to the block branch.
> >
>
> Is this going into 2.0?
Looks like we're going to have an -rc3, so yes.
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-04-11 12:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-10 1:33 [Qemu-devel] [PATCH] iscsi: Remember to set ret for iscsi_open in error case Fam Zheng
2014-04-10 11:11 ` Kevin Wolf
2014-04-11 5:29 ` Fam Zheng
2014-04-11 12:51 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).