From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40941)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1WYfNn-0007Hn-0p
	for qemu-devel@nongnu.org; Fri, 11 Apr 2014 13:37:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1WYfNh-00082J-Qp
	for qemu-devel@nongnu.org; Fri, 11 Apr 2014 13:36:54 -0400
Received: from mx1.redhat.com ([209.132.183.28]:15301)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1WYfNh-000822-IC
	for qemu-devel@nongnu.org; Fri, 11 Apr 2014 13:36:49 -0400
Date: Fri, 11 Apr 2014 13:36:44 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20140411133644.3bd1517c@redhat.com>
In-Reply-To: <1396177119-24955-5-git-send-email-kroosec@gmail.com>
References: <1396177119-24955-1-git-send-email-kroosec@gmail.com>
	<1396177119-24955-5-git-send-email-kroosec@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 04/17] monitor: Add chardev-remove id
 argument completion.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hani Benhabiles <kroosec@gmail.com>
Cc: kwolf@redhat.com, aliguori@amazon.com, qemu-devel@nongnu.org, stefanha@redhat.com, imammedo@redhat.com

On Sun, 30 Mar 2014 11:58:26 +0100
Hani Benhabiles <kroosec@gmail.com> wrote:

> Signed-off-by: Hani Benhabiles <hani@linux.com>

Gerd, can you review this one and the patch (04/18). Both look good
to me, btw.

> ---
>  hmp-commands.hx |  1 +
>  hmp.h           |  1 +
>  monitor.c       | 23 +++++++++++++++++++++++
>  3 files changed, 25 insertions(+)
> 
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index 4c4d261..4f0f053 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -1630,6 +1630,7 @@ ETEXI
>          .params     = "id",
>          .help       = "remove chardev",
>          .mhandler.cmd = hmp_chardev_remove,
> +        .command_completion = chardev_remove_completion,
>      },
>  
>  STEXI
> diff --git a/hmp.h b/hmp.h
> index 20ef454..42b4d6b 100644
> --- a/hmp.h
> +++ b/hmp.h
> @@ -97,5 +97,6 @@ void object_add_completion(ReadLineState *rs, int nb_args, const char *str);
>  void object_del_completion(ReadLineState *rs, int nb_args, const char *str);
>  void device_add_completion(ReadLineState *rs, int nb_args, const char *str);
>  void device_del_completion(ReadLineState *rs, int nb_args, const char *str);
> +void chardev_remove_completion(ReadLineState *rs, int nb_args, const char *str);
>  
>  #endif
> diff --git a/monitor.c b/monitor.c
> index 710ba25..040da9b 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -4346,6 +4346,29 @@ static void device_del_bus_completion(ReadLineState *rs,  BusState *bus,
>      }
>  }
>  
> +void chardev_remove_completion(ReadLineState *rs, int nb_args, const char *str)
> +{
> +    size_t len;
> +    ChardevInfoList *list, *start;
> +
> +    if (nb_args != 2) {
> +        return;
> +    }
> +    len = strlen(str);
> +    readline_set_completion_index(rs, len);
> +
> +    start = list = qmp_query_chardev(NULL);
> +    while (list) {
> +        ChardevInfo *chr = list->value;
> +
> +        if (!strncmp(chr->label, str, len)) {
> +            readline_add_completion(rs, chr->label);
> +        }
> +        list = list->next;
> +    }
> +    qapi_free_ChardevInfoList(start);
> +}
> +
>  void device_del_completion(ReadLineState *rs, int nb_args, const char *str)
>  {
>      size_t len;