From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYcPT-00048B-MI for qemu-devel@nongnu.org; Fri, 11 Apr 2014 10:26:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WYcPN-0003MR-Ar for qemu-devel@nongnu.org; Fri, 11 Apr 2014 10:26:27 -0400 Date: Fri, 11 Apr 2014 15:26:10 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20140411142610.GM2430@work-vm> References: <1396604722-11902-1-git-send-email-dmitry@daynix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1396604722-11902-1-git-send-email-dmitry@daynix.com> Subject: Re: [Qemu-devel] [PATCH V2 0/4] CVE-2013-4544 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dmitry Fleytman Cc: peter.maydell@linaro.org, "Michael S. Tsirkin" , qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, qemu-stable@nongnu.org, Stefan Hajnoczi , Paolo Bonzini * Dmitry Fleytman (dmitry@daynix.com) wrote: > Changes since V1: > > * Comments added and extended as sugested by Dave and Michael > > Dmitry Fleytman (4): > vmxnet3: validate interrupt indices coming from guest > vmxnet3: validate queues configuration coming from quest > vmxnet3: validate interrupt indices read on migration > vmxnet3: validate queues configuration read on migration I've reviewed all of those as OK; if you ever get the chance I think it would be nicer to try and avoid hw_error that causes an abort, especially when that's guest (even in this case a broken one) triggerable. But, lets get the fix in. Dave -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK