From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43360)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <l@dorileo.org>) id 1WfwQQ-0008Uq-Ol
	for qemu-devel@nongnu.org; Thu, 01 May 2014 15:13:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <l@dorileo.org>) id 1WfwQL-0004Gv-DX
	for qemu-devel@nongnu.org; Thu, 01 May 2014 15:13:42 -0400
Received: from mail-yk0-f169.google.com ([209.85.160.169]:44944)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <l@dorileo.org>) id 1WfwQL-0004Gh-9T
	for qemu-devel@nongnu.org; Thu, 01 May 2014 15:13:37 -0400
Received: by mail-yk0-f169.google.com with SMTP id 142so3058029ykq.28
	for <qemu-devel@nongnu.org>; Thu, 01 May 2014 12:13:36 -0700 (PDT)
Date: Thu, 1 May 2014 16:13:40 -0300
From: Leandro Dorileo <l@dorileo.org>
Message-ID: <20140501191340.GD29944@dorilex-lnv.MultilaserAP>
References: <1398762521-25733-1-git-send-email-cyliu@suse.com>
	<1398762521-25733-5-git-send-email-cyliu@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1398762521-25733-5-git-send-email-cyliu@suse.com>
Subject: Re: [Qemu-devel] [PATCH V26 04/32] qapi: output def_value_str when
 query command line options
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Chunyan Liu <cyliu@suse.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com

On Tue, Apr 29, 2014 at 05:08:13PM +0800, Chunyan Liu wrote:
> Change qapi interfaces to output the newly added def_value_str when querying
> command line options.
> 
> Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
> Signed-off-by: Chunyan Liu <cyliu@suse.com>


Reviewed-by: Leandro Dorileo <l@dorileo.org>


> ---
> Changes to V25:
>   * update @default description in .json file
> 
>  qapi-schema.json   | 5 ++++-
>  qmp-commands.hx    | 2 ++
>  util/qemu-config.c | 4 ++++
>  3 files changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 0b00427..880829d 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -4088,12 +4088,15 @@
>  #
>  # @help: #optional human readable text string, not suitable for parsing.
>  #
> +# @default: #optional default value string (since 2.1)
> +#
>  # Since 1.5
>  ##
>  { 'type': 'CommandLineParameterInfo',
>    'data': { 'name': 'str',
>              'type': 'CommandLineParameterType',
> -            '*help': 'str' } }
> +            '*help': 'str',
> +            '*default': 'str' } }
>  
>  ##
>  # @CommandLineOptionInfo:
> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index ed3ab92..1271332 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -2895,6 +2895,8 @@ Each array entry contains the following:
>                or 'size')
>      - "help": human readable description of the parameter
>                (json-string, optional)
> +    - "default": default value string for the parameter
> +                 (json-string, optional)
>  
>  Example:
>  
> diff --git a/util/qemu-config.c b/util/qemu-config.c
> index f4e4f38..ba375c0 100644
> --- a/util/qemu-config.c
> +++ b/util/qemu-config.c
> @@ -82,6 +82,10 @@ static CommandLineParameterInfoList *query_option_descs(const QemuOptDesc *desc)
>              info->has_help = true;
>              info->help = g_strdup(desc[i].help);
>          }
> +        if (desc[i].def_value_str) {
> +            info->has_q_default = true;
> +            info->q_default = g_strdup(desc[i].def_value_str);
> +        }
>  
>          entry = g_malloc0(sizeof(*entry));
>          entry->value = info;
> -- 
> 1.8.4.5
> 
> 

-- 
Leandro Dorileo