From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43716)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <l@dorileo.org>) id 1WfwSw-0002dI-LM
	for qemu-devel@nongnu.org; Thu, 01 May 2014 15:16:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <l@dorileo.org>) id 1WfwSr-0005R9-AY
	for qemu-devel@nongnu.org; Thu, 01 May 2014 15:16:18 -0400
Received: from mail-yh0-f54.google.com ([209.85.213.54]:50788)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <l@dorileo.org>) id 1WfwSr-0005R0-6d
	for qemu-devel@nongnu.org; Thu, 01 May 2014 15:16:13 -0400
Received: by mail-yh0-f54.google.com with SMTP id b6so3313906yha.13
	for <qemu-devel@nongnu.org>; Thu, 01 May 2014 12:16:12 -0700 (PDT)
Date: Thu, 1 May 2014 16:16:16 -0300
From: Leandro Dorileo <l@dorileo.org>
Message-ID: <20140501191616.GF29944@dorilex-lnv.MultilaserAP>
References: <1398762521-25733-1-git-send-email-cyliu@suse.com>
	<1398762521-25733-7-git-send-email-cyliu@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1398762521-25733-7-git-send-email-cyliu@suse.com>
Subject: Re: [Qemu-devel] [PATCH V26 06/32] QemuOpts: move qemu_opt_del
 ahead for later calling
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Chunyan Liu <cyliu@suse.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com

On Tue, Apr 29, 2014 at 05:08:15PM +0800, Chunyan Liu wrote:
> In later patch, qemu_opt_get_del functions will be added, they will
> first get the option value, then call qemu_opt_del to remove the option
> from opt list. To prepare for that purpose, move qemu_opt_del ahead first.
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Chunyan Liu <cyliu@suse.com>

Reviewed-by: Leandro Dorileo <l@dorileo.org>

> ---
>  util/qemu-option.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/util/qemu-option.c b/util/qemu-option.c
> index 69cdf3f..4d2d4d1 100644
> --- a/util/qemu-option.c
> +++ b/util/qemu-option.c
> @@ -567,6 +567,14 @@ static QemuOpt *qemu_opt_find(QemuOpts *opts, const char *name)
>      return NULL;
>  }
>  
> +static void qemu_opt_del(QemuOpt *opt)
> +{
> +    QTAILQ_REMOVE(&opt->opts->head, opt, next);
> +    g_free(opt->name);
> +    g_free(opt->str);
> +    g_free(opt);
> +}
> +
>  const char *qemu_opt_get(QemuOpts *opts, const char *name)
>  {
>      QemuOpt *opt = qemu_opt_find(opts, name);
> @@ -661,14 +669,6 @@ static void qemu_opt_parse(QemuOpt *opt, Error **errp)
>      }
>  }
>  
> -static void qemu_opt_del(QemuOpt *opt)
> -{
> -    QTAILQ_REMOVE(&opt->opts->head, opt, next);
> -    g_free(opt->name);
> -    g_free(opt->str);
> -    g_free(opt);
> -}
> -
>  static bool opts_accepts_any(const QemuOpts *opts)
>  {
>      return opts->list->desc[0].name == NULL;
> -- 
> 1.8.4.5
> 
> 

-- 
Leandro Dorileo