From: Leandro Dorileo <l@dorileo.org>
To: Chunyan Liu <cyliu@suse.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH V26 11/32] QemuOpts: check NULL input for qemu_opts_del
Date: Thu, 1 May 2014 16:25:41 -0300 [thread overview]
Message-ID: <20140501192541.GJ29944@dorilex-lnv.MultilaserAP> (raw)
In-Reply-To: <1398762521-25733-12-git-send-email-cyliu@suse.com>
On Tue, Apr 29, 2014 at 05:08:20PM +0800, Chunyan Liu wrote:
> To simplify later using of qemu_opts_del, accept NULL input.
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Chunyan Liu <cyliu@suse.com>
Reviewed-by: Leandro Dorileo <l@dorileo.org>
> ---
> util/qemu-option.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/util/qemu-option.c b/util/qemu-option.c
> index 4de99b3..2667e16 100644
> --- a/util/qemu-option.c
> +++ b/util/qemu-option.c
> @@ -1010,6 +1010,10 @@ void qemu_opts_del(QemuOpts *opts)
> {
> QemuOpt *opt;
>
> + if (opts == NULL) {
> + return;
> + }
> +
> for (;;) {
> opt = QTAILQ_FIRST(&opts->head);
> if (opt == NULL)
> --
> 1.8.4.5
>
>
--
Leandro Dorileo
next prev parent reply other threads:[~2014-05-01 19:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1398762521-25733-1-git-send-email-cyliu@suse.com>
[not found] ` <1398762521-25733-2-git-send-email-cyliu@suse.com>
2014-05-01 19:07 ` [Qemu-devel] [PATCH V26 01/32] QemuOpts: move find_desc_by_name ahead for later calling Leandro Dorileo
[not found] ` <1398762521-25733-3-git-send-email-cyliu@suse.com>
2014-05-01 19:10 ` [Qemu-devel] [PATCH V26 02/32] QemuOpts: add def_value_str to QemuOptDesc Leandro Dorileo
[not found] ` <1398762521-25733-4-git-send-email-cyliu@suse.com>
2014-05-01 19:12 ` [Qemu-devel] [PATCH V26 03/32] QemuOpts: repurpose qemu_opts_print to replace print_option_parameters Leandro Dorileo
[not found] ` <1398762521-25733-5-git-send-email-cyliu@suse.com>
2014-05-01 19:13 ` [Qemu-devel] [PATCH V26 04/32] qapi: output def_value_str when query command line options Leandro Dorileo
[not found] ` <1398762521-25733-6-git-send-email-cyliu@suse.com>
2014-05-01 19:15 ` [Qemu-devel] [PATCH V26 05/32] QemuOpts: change opt->name|str from (const char *) to (char *) Leandro Dorileo
[not found] ` <1398762521-25733-7-git-send-email-cyliu@suse.com>
2014-05-01 19:16 ` [Qemu-devel] [PATCH V26 06/32] QemuOpts: move qemu_opt_del ahead for later calling Leandro Dorileo
[not found] ` <1398762521-25733-8-git-send-email-cyliu@suse.com>
2014-05-01 19:17 ` [Qemu-devel] [PATCH V26 07/32] QemuOpts: add qemu_opt_get_*_del functions for replace work Leandro Dorileo
[not found] ` <1398762521-25733-9-git-send-email-cyliu@suse.com>
2014-05-01 19:19 ` [Qemu-devel] [PATCH V26 08/32] QemuOpts: add qemu_opts_print_help to replace print_option_help Leandro Dorileo
[not found] ` <1398762521-25733-10-git-send-email-cyliu@suse.com>
2014-05-01 19:24 ` [Qemu-devel] [PATCH V26 09/32] QemuOpts: add conversion between QEMUOptionParameter to QemuOpts Leandro Dorileo
[not found] ` <1398762521-25733-12-git-send-email-cyliu@suse.com>
2014-05-01 19:25 ` Leandro Dorileo [this message]
[not found] ` <1398762521-25733-13-git-send-email-cyliu@suse.com>
2014-05-01 22:09 ` [Qemu-devel] [PATCH V26 12/32] change block layer to support both QemuOpts and QEMUOptionParamter Leandro Dorileo
2014-05-05 9:03 ` Chun Yan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140501192541.GJ29944@dorilex-lnv.MultilaserAP \
--to=l@dorileo.org \
--cc=cyliu@suse.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).