From: Stefan Hajnoczi <stefanha@gmail.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: Benoit Canet <benoit@irqsave.net>,
qemu-devel@nongnu.org, Christophe Fergeau <cfergeau@redhat.com>,
Alon Levy <alevy@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/5] do not call g_thread_init() for glib >= 2.31
Date: Fri, 2 May 2014 11:41:25 +0200 [thread overview]
Message-ID: <20140502094125.GH8005@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1398751349-20869-2-git-send-email-mjt@msgid.tls.msk.ru>
On Tue, Apr 29, 2014 at 10:02:24AM +0400, Michael Tokarev wrote:
> glib >= 2.31 always enables thread support and g_thread_supported()
> is #defined to 1, there's no need to call g_thread_init() anymore,
> and it definitely does not need to report error which never happens.
> Keep code for old < 2.31 glibc anyway for now, just #ifdef it
> differently.
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> coroutine-gthread.c | 7 ++-----
> util/osdep.c | 21 +++++++++------------
> 2 files changed, 11 insertions(+), 17 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
next parent reply other threads:[~2014-05-02 9:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1398751349-20869-1-git-send-email-mjt@msgid.tls.msk.ru>
[not found] ` <1398751349-20869-2-git-send-email-mjt@msgid.tls.msk.ru>
2014-05-02 9:41 ` Stefan Hajnoczi [this message]
[not found] ` <1398751349-20869-3-git-send-email-mjt@msgid.tls.msk.ru>
2014-05-02 9:45 ` [Qemu-devel] [PATCH 2/5] glib-compat.h: add new thread API emulation on top of pre-2.31 API Stefan Hajnoczi
2014-05-02 12:11 ` Michael Tokarev
2014-05-05 14:49 ` [Qemu-devel] [PATCH 0/5] glib thread interface and libcacard cleanups Alon Levy
2014-05-05 16:36 ` Michael Tokarev
2014-05-06 9:22 ` Alon Levy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140502094125.GH8005@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=alevy@redhat.com \
--cc=benoit@irqsave.net \
--cc=cfergeau@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).